Skip to content

Conversation

@ZihanLi58
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    This PR is to abstract comparable watermark so that it support different type of offset value.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Unit test and test in Azkaban to make sure this is a backward compatible change

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@AllArgsConstructor
@EqualsAndHashCode
public class StringWatermark implements ComparableWatermark {
public class StringWatermark implements ComparableWatermark<String> {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any tests that validates this change. How is it verified? Could you help confirm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no API change in this class at all. i.e. the getValue still return String type and the way to construct the class still remain the same. So I think we don't need test for this part. Let me know if you still have concerns about this.

@ZihanLi58 ZihanLi58 merged commit 36cdf2b into apache:master Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants