[GOBBLIN-2049] Configure Gobblin Distcp Writer to fail if setPermission fails #3929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will-Lo
requested changes
Apr 18, 2024
...main/java/org/apache/gobblin/data/management/copy/writer/FileAwareInputStreamDataWriter.java
Outdated
Show resolved
Hide resolved
Will-Lo
approved these changes
Apr 18, 2024
phet
reviewed
Apr 18, 2024
...ement/src/main/java/org/apache/gobblin/data/management/copy/publisher/CopyDataPublisher.java
Outdated
Show resolved
Hide resolved
| public static final String GOBBLIN_COPY_TASK_OVERWRITE_ON_COMMIT = "gobblin.copy.task.overwrite.on.commit"; | ||
| public static final boolean DEFAULT_GOBBLIN_COPY_TASK_OVERWRITE_ON_COMMIT = false; | ||
| public static final String GOBBLIN_COPY_REQUIRE_PERMISSION_SET_FOR_SUCCESS = "gobblin.copy.requirePermissionSetForSuccess"; | ||
| public static final boolean DEFAULT_COPY_REQUIRE_PERMISSION_SET_FOR_SUCCESS = false; |
Contributor
There was a problem hiding this comment.
when wouldn't one want failure? I'd be more aggressive in choosing the default. while it does require a config change, one can always easily revert to the legacy semantics.
so while not b/w-compat, quite easily opted-into, as desired
Contributor
Author
There was a problem hiding this comment.
Sure, I was also debating making the default true instead. I'll change.
phet
approved these changes
Apr 19, 2024
| protected final boolean preserveDirModTime; | ||
| protected final boolean resyncDirOwnerAndPermission; | ||
| protected final boolean requirePermissionSetForSuccess; | ||
| protected final boolean shouldFailWhenPermissionFail; |
Contributor
There was a problem hiding this comment.
nit: when permissions fail (preferred!) or when permission fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Tests
Gobblin
safeSetPathPermissiondoes not throw an exception when setting permissions fail on a path. We want to change this behavior especially for use cases like manifest distcp where hundreds of thousands of files are involved in a distcp job and permission settings are important to replicate correctly as they cannot be updated or verified by hand.This PR adds a new configuration to fail writing or publishing tasks when the job is configured to report success when permissions are not replicated properly. The default behavior remains the same as before to allow the job to succeed without this for backwards compatibility.
Commits