Skip to content

Conversation

@Will-Lo
Copy link
Contributor

@Will-Lo Will-Lo commented May 2, 2024

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    jobStatus was an ambiguous metric name for counting job successes and detecting failure, so changing the metric name to better reflect it.

Also move logs to be debug logs as they are emitted very frequently (every minute)

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Unit tests

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@Will-Lo Will-Lo changed the title Change jobStatus opentelemetry metric to flowSucceeded to better reflect metric values [GOBBLIN-2060] Change jobStatus opentelemetry metric to flowSucceeded to better reflect metric values May 2, 2024
@Will-Lo Will-Lo merged commit 354c78d into apache:master May 2, 2024
@Will-Lo Will-Lo deleted the modify-jobstatus-observability-event branch May 2, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants