Job state stored in distributed cache in MR mode.#913
Merged
ibuenros merged 1 commit intoapache:masterfrom Apr 15, 2016
Merged
Conversation
Contributor
Author
|
@chavdar @sahilTakiar can you review? This addresses https://github.com/linkedin/gobblin/issues/911 |
| Path jobStateFilePath = new Path(this.mrJobDir, JOB_STATE_FILE_NAME); | ||
| SerializationUtils.serializeState(this.fs, jobStateFilePath, this.jobContext.getJobState(), 100); | ||
| SerializationUtils.serializeState(this.fs, jobStateFilePath, this.jobContext.getJobState()); | ||
| DistributedCache.addCacheFile(jobStateFilePath.toUri(), this.job.getConfiguration()); |
Contributor
There was a problem hiding this comment.
We should use MRJobLauncher.addHDFSFiles which already does this, it also sets up a symlink to the file, this way the additional property JOB_STATE_DISTRIBUTED_CACHE_NAME should not longer be necessary.
Using the symlink should also simply the code added to the setup method.
ibuenros
force-pushed
the
serialize-state-replication
branch
from
210c4e2 to
ad6634b
Compare
Contributor
Author
|
@sahilTakiar I tried using |
ibuenros
force-pushed
the
serialize-state-replication
branch
from
ad6634b to
3ea72ab
Compare
Contributor
Author
|
Talked with @sahilTakiar offline. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.