GORA-459

[renato2099]

Fixing HBaseClusterSingleton.java unclosed resources returned from HBaseTestingUtility

[lewismc]

+1

On Sunday, January 17, 2016, Renato Marroquin notifications@github.com
wrote:

Fixing HBaseClusterSingleton.java unclosed resources returned from

HBaseTestingUtility

You can view, comment on, or merge this pull request online at:

#51
Commit Summary

• GORA-459

File Changes

• M
  gora-hbase/src/test/java/org/apache/gora/hbase/util/HBaseClusterSingleton.java
  https://github.com/apache/gora/pull/51/files#diff-0 (7)

Patch Links:

• https://github.com/apache/gora/pull/51.patch
• https://github.com/apache/gora/pull/51.diff

—
Reply to this email directly or view it on GitHub
#51.

Lewis

[renato2099]

Can you commit this and the other PRs @lewismc please? I don't know why I don't have right to actually do the merging myself. Thanks man!

[lewismc]

Yeah I can but it would be good to sort the commit issue out.
Are your trying to commit to the Git repos or the Github mirror?

On Monday, January 18, 2016, Renato Marroquin notifications@github.com
wrote:

Can you commit this and the other PRs @lewismc
https://github.com/lewismc please? I don't know why I don't have right
to actually do the merging myself. Thanks man!

—
Reply to this email directly or view it on GitHub
#51 (comment).

Lewis

[renato2099]

I can commit through the cmd line git commands, but I can't merge the PR from the github website, can you do that? or do you the commits directly from the cmd line?

[lewismc]

Yeah it's all commits through the CLI to the canonical source at Apache. As
the Github mirror is not canonical source, the merge functionality is
disabled.

On Monday, January 18, 2016, Renato Marroquin notifications@github.com
wrote:

I can commit through the cmd line git commands, but I can't merge the PR
from the github website, can you do that? or do you the commits directly
from the cmd line?

—
Reply to this email directly or view it on GitHub
#51 (comment).

Lewis

[renato2099]

got it, then you wanna merge? or should I? 👍

[lewismc]

If you can then please go ahead. I'm out and about now.
I'll merge this into my HBase branch and submit a PR once it's ready.
Thanks Renato.

On Monday, January 18, 2016, Renato Marroquin notifications@github.com
wrote:

got it, then you wanna merge? or should I? [image: 👍]

—
Reply to this email directly or view it on GitHub
#51 (comment).

Lewis