GORA-362 Refactor gora-dynamodb to support avro serialization#56
Merged
asfgit merged 1 commit intoapache:masterfrom Mar 16, 2016
Merged
GORA-362 Refactor gora-dynamodb to support avro serialization#56asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
This is awesome mate! I really thought I had lost this. |
Member
Author
|
I am +1 for it. In it's current state e.g. master, gora-dynamodb is kinda broken, It is also severaly behind the aws java SDK meaning that I am not even sure we can persist data into dynamodb anymore. |
Contributor
|
yeah I think we can at least start moving that direction 👍 |
asfgit
pushed a commit
that referenced
this pull request
Mar 16, 2016
Contributor
|
there still some more work to get it done, but I think we are moving in the right direction with this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @renato2099 OK here it is in all of it's glory... and what a patch it is!
This is a beast!
I've tested it locally and all working well. I updated a number of areas, fixed a few bugs and also made the patch compliant with the forbidden api's checks.
This issue relates to https://issues.apache.org/jira/browse/GORA-362
What an effort this was by you first time around... kudos mate.