Skip to content

GORA-362 Refactor gora-dynamodb to support avro serialization#56

Merged
asfgit merged 1 commit intoapache:masterfrom
lewismc:GORA-362
Mar 16, 2016
Merged

GORA-362 Refactor gora-dynamodb to support avro serialization#56
asfgit merged 1 commit intoapache:masterfrom
lewismc:GORA-362

Conversation

@lewismc
Copy link
Member

@lewismc lewismc commented Feb 27, 2016

Hi @renato2099 OK here it is in all of it's glory... and what a patch it is!
This is a beast!
I've tested it locally and all working well. I updated a number of areas, fixed a few bugs and also made the patch compliant with the forbidden api's checks.
This issue relates to https://issues.apache.org/jira/browse/GORA-362
What an effort this was by you first time around... kudos mate.

@renato2099
Copy link
Contributor

This is awesome mate! I really thought I had lost this.
Maybe we can commit this as an initial patch and start working from there? wdyt @lewismc ?

@lewismc
Copy link
Member Author

lewismc commented Mar 9, 2016

I am +1 for it. In it's current state e.g. master, gora-dynamodb is kinda broken, It is also severaly behind the aws java SDK meaning that I am not even sure we can persist data into dynamodb anymore.
I would be +1 for committing this patch, it tests, it builds ,etc.
Anyone else have comments?

@renato2099
Copy link
Contributor

yeah I think we can at least start moving that direction 👍

@asfgit asfgit merged commit 655cd3a into apache:master Mar 16, 2016
asfgit pushed a commit that referenced this pull request Mar 16, 2016
@renato2099
Copy link
Contributor

there still some more work to get it done, but I think we are moving in the right direction with this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants