CI, Build and Test updates#14668
Merged
Merged
Conversation
jdaugherty
reviewed
Apr 24, 2025
jdaugherty
reviewed
Apr 24, 2025
- Address intermittent CI failures possibly caused by date values not incrementing as expected. - Enhance assertions by comparing `.time` values to reveal the actual millisecond differences. - Remove annotations that were added as a try to remedy the flakiness, to determine if they are warranted. - Omit cleanup of `insertOverwrite`, to determine if it is necessary for test stability. - Do one comparison per statement in `then` blocks.
The test was failing on Windows due to line-ending differences affecting string comparisons.
- Apply the `asset-pipeline` Gradle plugin to functional test projects where it was missing. - This adds `org.graalvm.js:js-community (required by `asset-pipeline-grails`) to the `runtimeClasspath`. - Without this, we get `ClassNotFoundException: org.graalvm.polyglot.Context`.
Attempting to re-enable the test on Windows, as it seems to pass in local environments.
- Clarify comment why `GITHUB_TOKEN` is added as an environment variable. - Align lists to use space padding for readability. - Align `.gradlew` linebreaks. - Align `setup-java` params to use alphabetical ascending order. - Remove unused step ids. - Use `bootJar` and `check` task instead of `build` in functional test jobs as we don't have to do a full build there (docs etc.). - Align on adding `--continue` and `--stacktrace` for test jobs. - Align on `ubuntu-24.04` instead of `ubuntu-latest` for non-os-matrixed jobs (for stability).
Removes log output: [converterClass] attribute is deprecated and replaced by [class]
To make the build a little less noisy.
This prevents timeouts when `repo.grails.org` is proxying.
The default permissions should suffice for what we are doing.
matrei
force-pushed
the
custom-timestamp-test
branch
from
7666190 to
db1fd61
Compare
This will show the page source output on test failures.
matrei
force-pushed
the
custom-timestamp-test
branch
from
d6c1fcb to
4d08256
Compare
`testFormActionSubmitWithController` fails for some reason only in CI. It seems that `createLink` from `ApplicationTagLib` returns an empty string.
jdaugherty
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CustomAutoTimestampSpec.timevalues to reveal the actual millisecond differences.insertOverwrite, to determine if it is necessary for test stability.thenblocks.GroovyPageUnitTestMixinWithCustomViewDirSpecon Windowsasset-pipelineGradle plugin in some test applications with assetsorg.graalvm.js:js-communityon theruntimeClasspathand avoidsClassNotFoundException: org.graalvm.polyglot.Context.TckTestSuiteon Windows as it does not seem to failgradle.ymlconverterClassattributes inlogback.xmlgrails-gradlelifecycletoinfoto clean up the log output a bit.mavenCentralrepository to Gradle Plugin e2e tests.@PendingFeatureIffor tests that only fail inCI.