Remove remnants of `doWithWebDescriptor` by matrei · Pull Request #15500 · apache/grails-core

matrei · 2026-03-12T12:42:21Z

Also, clean up the javadoc in some classes related to Grails plugins.

grails-core/src/main/groovy/grails/plugins/GrailsPluginManager.java

bito-code-review · 2026-03-18T22:20:38Z

The second option is clearer and more precise, as 'no plugin is defined for the instance' better conveys that no plugin exists to handle it, compared to the ambiguous 'no plugin defined the instance.'

And add tests.

And add `@see` reference to `GrailsPluginManager`.

matrei · 2026-03-19T15:53:17Z

The GrailsPluginMetadataTests needs #15518 to be merged first to succeed.

testlens-app · 2026-03-19T19:12:13Z

🚨 TestLens detected 43 failed tests 🚨

Here is what you can do:

Inspect the test failures carefully.
If you are convinced that some of the tests are flaky, you can mute them below.
Finally, trigger a rerun by checking the rerun checkbox.

Test Summary

Check	Project/Task	Test	Runs
CI - Groovy Joint Validation Build / build_grails	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin path for classes > returns plugin path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, #1]	❌
CI - Groovy Joint Validation Build / build_grails	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin path for instances > returns plugin path for instances [instance: <org.grails.plugins.metadata.Test2@63d677f5>, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, #1]	❌
CI - Groovy Joint Validation Build / build_grails	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin views path for classes > returns plugin views path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, #1]	❌
CI - Groovy Joint Validation Build / build_grails	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin views path for instances > returns plugin views path for instances [instance: <org.grails.plugins.metadata.Test2@743c3520>, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, #1]	❌
CI - Groovy Joint Validation Build / build_grails	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugins for classes > returns plugins for classes [clazz: class org.grails.plugins.metadata.Test2, name: dataBinding, #1]	❌
CI - Groovy Joint Validation Build / build_grails	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugins for instances > returns plugins for instances [instance: <org.grails.plugins.metadata.Test2@c3719e5>, name: dataBinding, #1]	❌
CI / Build Grails-Core (macos-latest, 21)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin path for classes > returns plugin path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, #1]	❌
CI / Build Grails-Core (macos-latest, 21)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin path for instances > returns plugin path for instances [instance: <org.grails.plugins.metadata.Test2@47187f50>, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, #1]	❌
CI / Build Grails-Core (macos-latest, 21)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin views path for classes > returns plugin views path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, #1]	❌
CI / Build Grails-Core (macos-latest, 21)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin views path for instances > returns plugin views path for instances [instance: <org.grails.plugins.metadata.Test2@3de79067>, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, #1]	❌
CI / Build Grails-Core (macos-latest, 21)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugins for classes > returns plugins for classes [clazz: class org.grails.plugins.metadata.Test2, name: dataBinding, #1]	❌
CI / Build Grails-Core (macos-latest, 21)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugins for instances > returns plugins for instances [instance: <org.grails.plugins.metadata.Test2@626e0c86>, name: dataBinding, #1]	❌
CI / Build Grails-Core (ubuntu-latest, 17)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin path for classes > returns plugin path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, #1]	❌
CI / Build Grails-Core (ubuntu-latest, 17)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin path for instances > returns plugin path for instances [instance: <org.grails.plugins.metadata.Test2@eabecf5>, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, #1]	❌
CI / Build Grails-Core (ubuntu-latest, 17)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin views path for classes > returns plugin views path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, #1]	❌
CI / Build Grails-Core (ubuntu-latest, 17)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin views path for instances > returns plugin views path for instances [instance: <org.grails.plugins.metadata.Test2@4e25282d>, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, #1]	❌
CI / Build Grails-Core (ubuntu-latest, 17)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugins for classes > returns plugins for classes [clazz: class org.grails.plugins.metadata.Test2, name: dataBinding, #1]	❌
CI / Build Grails-Core (ubuntu-latest, 17)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugins for instances > returns plugins for instances [instance: <org.grails.plugins.metadata.Test2@3450bd13>, name: dataBinding, #1]	❌
CI / Build Grails-Core (ubuntu-latest, 21)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin path for classes > returns plugin path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, #1]	❌
CI / Build Grails-Core (ubuntu-latest, 21)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin path for instances > returns plugin path for instances [instance: <org.grails.plugins.metadata.Test2@347f8029>, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, #1]	❌
CI / Build Grails-Core (ubuntu-latest, 21)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin views path for classes > returns plugin views path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, #1]	❌
CI / Build Grails-Core (ubuntu-latest, 21)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin views path for instances > returns plugin views path for instances [instance: <org.grails.plugins.metadata.Test2@31de8099>, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, #1]	❌
CI / Build Grails-Core (ubuntu-latest, 21)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugins for classes > returns plugins for classes [clazz: class org.grails.plugins.metadata.Test2, name: dataBinding, #1]	❌
CI / Build Grails-Core (ubuntu-latest, 21)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugins for instances > returns plugins for instances [instance: <org.grails.plugins.metadata.Test2@58945295>, name: dataBinding, #1]	❌
CI / Build Grails-Core (ubuntu-latest, 25)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin path for classes > returns plugin path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, #1]	❌
CI / Build Grails-Core (ubuntu-latest, 25)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin path for instances > returns plugin path for instances [instance: <org.grails.plugins.metadata.Test2@f833223>, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, #1]	❌
CI / Build Grails-Core (ubuntu-latest, 25)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin views path for classes > returns plugin views path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, #1]	❌
CI / Build Grails-Core (ubuntu-latest, 25)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin views path for instances > returns plugin views path for instances [instance: <org.grails.plugins.metadata.Test2@2fd8b081>, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, #1]	❌
CI / Build Grails-Core (ubuntu-latest, 25)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugins for classes > returns plugins for classes [clazz: class org.grails.plugins.metadata.Test2, name: dataBinding, #1]	❌
CI / Build Grails-Core (ubuntu-latest, 25)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugins for instances > returns plugins for instances [instance: <org.grails.plugins.metadata.Test2@53917c92>, name: dataBinding, #1]	❌
CI / Build Grails-Core (windows-latest, 25)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin path for classes > returns plugin path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, #1]	❌
CI / Build Grails-Core (windows-latest, 25)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin path for instances > returns plugin path for instances [instance: <org.grails.plugins.metadata.Test2@23cb8fcb>, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, #1]	❌
CI / Build Grails-Core (windows-latest, 25)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin views path for classes > returns plugin views path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, #1]	❌
CI / Build Grails-Core (windows-latest, 25)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin views path for instances > returns plugin views path for instances [instance: <org.grails.plugins.metadata.Test2@34fcc5e3>, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, #1]	❌
CI / Build Grails-Core (windows-latest, 25)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugins for classes > returns plugins for classes [clazz: class org.grails.plugins.metadata.Test2, name: dataBinding, #1]	❌
CI / Build Grails-Core (windows-latest, 25)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugins for instances > returns plugins for instances [instance: <org.grails.plugins.metadata.Test2@185bf6e0>, name: dataBinding, #1]	❌
CI / Build Grails-Core Rerunning all Tasks (ubuntu-latest, 17)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin path for classes > returns plugin path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, #1]	❌
CI / Build Grails-Core Rerunning all Tasks (ubuntu-latest, 17)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin path for instances > returns plugin path for instances [instance: <org.grails.plugins.metadata.Test2@75b3ef1a>, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, #1]	❌
CI / Build Grails-Core Rerunning all Tasks (ubuntu-latest, 17)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin views path for classes > returns plugin views path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, #1]	❌
CI / Build Grails-Core Rerunning all Tasks (ubuntu-latest, 17)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugin views path for instances > returns plugin views path for instances [instance: <org.grails.plugins.metadata.Test2@7aa1fb0e>, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, #1]	❌
CI / Build Grails-Core Rerunning all Tasks (ubuntu-latest, 17)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugins for classes > returns plugins for classes [clazz: class org.grails.plugins.metadata.Test2, name: dataBinding, #1]	❌
CI / Build Grails-Core Rerunning all Tasks (ubuntu-latest, 17)	:grails-test-suite-uber:test	GrailsPluginMetadataTests > returns plugins for instances > returns plugins for instances [instance: <org.grails.plugins.metadata.Test2@4d66cb>, name: dataBinding, #1]	❌
CI / Functional Tests (Java 21, indy=false)	:grails-test-examples-scaffolding:integrationTest	UserControllerSpec > User list	❌

🏷️ Commit: e0aff6f
▶️ Tests: 42701 executed
⚪️ Checks: 35/35 completed

Test Failures (first 5 of 43)

GrailsPluginMetadataTests > returns plugin path for classes > returns plugin path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, #1] (:grails-test-suite-uber:test in CI / Build Grails-Core (macos-latest, 21))

Condition not satisfied:

path == expectedPath
|    |  |
""   |  /plugins/data-binding-7.1.0-SNAPSHOT
     false
     36 differences (0% similarity)
     (------------------------------------)
     (/plugins/data-binding-7.1.0-SNAPSHOT)

	at org.grails.plugins.metadata.GrailsPluginMetadataTests.returns plugin path for classes(GrailsPluginMetadataTests.groovy:87)

expected	actual
~~/plugins/data-binding-7.1.0-SNAPSHOT~~

GrailsPluginMetadataTests > returns plugin path for instances > returns plugin path for instances [instance: , expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, #1] (:grails-test-suite-uber:test in CI / Build Grails-Core (macos-latest, 21))

Condition not satisfied:

path == expectedPath
|    |  |
""   |  /plugins/data-binding-7.1.0-SNAPSHOT
     false
     36 differences (0% similarity)
     (------------------------------------)
     (/plugins/data-binding-7.1.0-SNAPSHOT)

	at org.grails.plugins.metadata.GrailsPluginMetadataTests.returns plugin path for instances(GrailsPluginMetadataTests.groovy:73)

expected	actual
~~/plugins/data-binding-7.1.0-SNAPSHOT~~

GrailsPluginMetadataTests > returns plugin views path for classes > returns plugin views path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, #1] (:grails-test-suite-uber:test in CI / Build Grails-Core (macos-latest, 21))

Condition not satisfied:

viewsPath == expectedPath
|         |  |
null      |  /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views
          false

	at org.grails.plugins.metadata.GrailsPluginMetadataTests.returns plugin views path for classes(GrailsPluginMetadataTests.groovy:115)

expected	actual
~~/plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views~~	null

GrailsPluginMetadataTests > returns plugin views path for instances > returns plugin views path for instances [instance: , expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, #1] (:grails-test-suite-uber:test in CI / Build Grails-Core (macos-latest, 21))

Condition not satisfied:

viewsPath == expectedPath
|         |  |
null      |  /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views
          false

	at org.grails.plugins.metadata.GrailsPluginMetadataTests.returns plugin views path for instances(GrailsPluginMetadataTests.groovy:101)

expected	actual
~~/plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views~~	null

GrailsPluginMetadataTests > returns plugins for classes > returns plugins for classes [clazz: class org.grails.plugins.metadata.Test2, name: dataBinding, #1] (:grails-test-suite-uber:test in CI / Build Grails-Core (macos-latest, 21))

Condition not satisfied:

plugin?.name == name
|       |    |  |
null    null |  dataBinding
             false

	at org.grails.plugins.metadata.GrailsPluginMetadataTests.returns plugins for classes(GrailsPluginMetadataTests.groovy:59)

expected	actual
~~dataBinding~~	null

Muted Tests

Select tests to mute in this pull request:

GrailsPluginMetadataTests > returns plugin path for classes
GrailsPluginMetadataTests > returns plugin path for instances
GrailsPluginMetadataTests > returns plugin views path for classes
GrailsPluginMetadataTests > returns plugin views path for instances
GrailsPluginMetadataTests > returns plugins for classes
GrailsPluginMetadataTests > returns plugins for instances
UserControllerSpec > User list

Reuse successful test results:

♻️ Only rerun the tests that failed or were muted before

Click the checkbox to trigger a rerun:

Rerun jobs

Learn more about TestLens at testlens.app.

fix: remove remnants of doWithWebDescriptor

a862264

Also, clean up the javadoc in some classes related to Grails plugins.

github-project-automation bot added this to Apache Grails Mar 12, 2026

jamesfredley approved these changes Mar 18, 2026

View reviewed changes

grails-core/src/main/groovy/grails/plugins/GrailsPluginManager.java Outdated Show resolved Hide resolved

matrei added 3 commits March 19, 2026 16:09

docs: more javadoc updates GrailsPluginManager

54a6f4d

test: convert GrailsPluginMetadataTests to Spock

fe8a90a

And add tests.

docs: remove duplicate javadoc in DefaultGrailsPluginManager

a461811

And add `@see` reference to `GrailsPluginManager`.

This comment has been minimized.

Sign in to view

docs: add that a plugin class extends Plugin

e0aff6f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove remnants of `doWithWebDescriptor`#15500

Remove remnants of `doWithWebDescriptor`#15500
matrei wants to merge 5 commits into7.1.xfrom
matrei/cleanup-do-with-web

matrei commented Mar 12, 2026

Uh oh!

Uh oh!

bito-code-review bot commented Mar 18, 2026

Uh oh!

This comment has been minimized.

matrei commented Mar 19, 2026

Uh oh!

testlens-app bot commented Mar 19, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

matrei commented Mar 12, 2026

Uh oh!

Uh oh!

bito-code-review bot commented Mar 18, 2026

Uh oh!

This comment has been minimized.

matrei commented Mar 19, 2026

Uh oh!

testlens-app bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨 TestLens detected 43 failed tests 🚨

Test Summary

Test Failures (first 5 of 43)

Muted Tests

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

testlens-app bot commented Mar 19, 2026 •

edited

Loading