Do not fail mergeTestReports for partial previous test task runs#15563
Do not fail mergeTestReports for partial previous test task runs#15563jdaugherty merged 2 commits into7.1.xfrom
Conversation
ab4d44f to
46e57a1
Compare
✅ All tests passed ✅🏷️ Commit: 46e57a1 Learn more about TestLens at testlens.app. |
| constraints { | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
FYI: This may be a regression with 7.1. There was a swallowed exception I noticed while working on this change because these views didn't exist in this project. It may be related to Scott's wildcard mapping change. Although, I think it doesn't have a real impact so it's probably ok.
|
The change removes URL mappings to views ('/index', '/error', '/notFound') that don't exist in the project, which were causing swallowed exceptions in Grails 7.1, likely due to wildcard mapping updates. Removing them prevents errors without impact, as these are default fallbacks. This appears to be a valid fix for the regression. grails-test-examples/test-phases/grails-app/controllers/testphases/UrlMappings.groovy |
If a user:
The mergeTestReports will fail b/c it's partially run, an error like this will show:
This is because the index file isn't generated until after the task finishes. This PR simply removes these invalid states so the test report task doesn't fail.