Skip to content

Spring security updates#15609

Merged
jdaugherty merged 4 commits into8.0.xfrom
springSecurityUpdates
Apr 29, 2026
Merged

Spring security updates#15609
jdaugherty merged 4 commits into8.0.xfrom
springSecurityUpdates

Conversation

@jdaugherty
Copy link
Copy Markdown
Contributor

Spring Boot 4.x compatible Spring Security

@jdaugherty
Copy link
Copy Markdown
Contributor Author

I added the ability to skip forcing all tasks to run as part of this PR, i.e.

         DO_NOT_CACHE_TESTS=1 ./gradlew check 

This will run all tests but use the cached versions of other tasks.

@jdaugherty
Copy link
Copy Markdown
Contributor Author

@jamesfredley @matrei looks like all of the spring security tests are working in 8.0.x again so I think we can merge.

@jdaugherty jdaugherty added the relates-to:v8 Grails 8 label Apr 29, 2026
Comment thread build-logic/docs-core/build.gradle Outdated
@bito-code-review
Copy link
Copy Markdown

No, the suggestion isn’t fully correct — using ?.toBoolean() results in null when the environment variable is unset, which will cause a runtime error in boolean expressions like !doNotCacheTests, whereas the current 'as Boolean' cast safely defaults to false.

@matrei
Copy link
Copy Markdown
Contributor

matrei commented Apr 29, 2026

No, the suggestion isn’t fully correct — using ?.toBoolean() results in null when the environment variable is unset, which will cause a runtime error in boolean expressions like !doNotCacheTests, whereas the current 'as Boolean' cast safely defaults to false.

If the variable is typed as boolean, null will be coerced to false. Using toBoolean() will properly parse input values: '1', 'true', 'y' etc. to true.

@jdaugherty jdaugherty requested a review from matrei April 29, 2026 12:29
Comment thread build-logic/docs-core/build.gradle Outdated
@jdaugherty jdaugherty requested a review from matrei April 29, 2026 18:03
@testlens-app
Copy link
Copy Markdown

testlens-app Bot commented Apr 29, 2026

✅ All tests passed ✅

🏷️ Commit: 921e8e1
▶️ Tests: 38128 executed
⚪️ Checks: 35/35 completed


Learn more about TestLens at testlens.app.

@jdaugherty jdaugherty merged commit 1b33cf8 into 8.0.x Apr 29, 2026
35 of 36 checks passed
@jdaugherty jdaugherty deleted the springSecurityUpdates branch April 29, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants