Ensure that the GlobalGrailsClassInjectorTransformation fails in the grails-core build if the wrong directory is passed#15799
Merged
Merged
Conversation
…grails-core build if the wrong directory is passed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.0.x #15799 +/- ##
==================================================
+ Coverage 49.4560% 49.4955% +0.0395%
- Complexity 16640 16701 +61
==================================================
Files 1944 1947 +3
Lines 92379 92473 +94
Branches 16130 16152 +22
==================================================
+ Hits 45687 45770 +83
+ Misses 39594 39593 -1
- Partials 7098 7110 +12
🚀 New features to boost your workflow:
|
matrei
approved these changes
Jul 1, 2026
matrei
left a comment
Contributor
There was a problem hiding this comment.
Strange that Gradle would have such a bug.
|
|
||
| void "findSourceDirectory walks up to the project directory when base.dir is not set"() { | ||
| given: "no base.dir and a standard per-project compile target" | ||
| System.clearProperty('base.dir') |
Contributor
There was a problem hiding this comment.
Suggested change
| System.clearProperty('base.dir') |
Contributor
Author
There was a problem hiding this comment.
For consistent state I think we should always clear before running the test. I've added a RestoreSystemProperties to the top though.
sbglasius
approved these changes
Jul 1, 2026
Co-authored-by: Mattias Reichel <matrei@apache.org>
Co-authored-by: Mattias Reichel <matrei@apache.org>
Co-authored-by: Søren Berg Glasius <soeren@glasius.dk>
This comment has been minimized.
This comment has been minimized.
Contributor
|
Not surprising to me, unfortunately. But is is nice we can usually wrap it with a little duct tape and move forward thanks to Groovy. |
jamesfredley
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After trying to build the 8.0.x build, it was not reproducible because the grails.factories file in grails-core was merged with grails-core & grails-gsp projects somehow. The only way I can see this happening is if there is an incorrect base directory or a missing directory. This change is meant to be a "catch all" to find these cases. The goal is to merge this and then retry the 8.0.0-M2 build and see if this helps.