Updated Junit to 4.11 #340
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
Author
|
This pull request should not be merged until a new version of Spock is released which incorporates this change (update Spock to JUnit 4.11): spockframework/spock@fb46cfc |
Contributor
Author
|
JUnit was upgraded separately, so closing this pull request -- b079427 |
jdaugherty
pushed a commit
to jdaugherty/grails-core
that referenced
this pull request
Jan 15, 2025
* Revert "Update project to Groovy 3.0.19 (apache#339)" (apache#340) This reverts commit 166db0a. * Revert "Revert "Update project to Groovy 3.0.19 (apache#339)" (apache#340)" (apache#341) This reverts commit 147212246f680efceddd84b62d69fcda42a4cfb1. * Update gormVersion to v8.0.3 --------- Co-authored-by: Puneet Behl <behlp@unityfoundation.io> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jdaugherty
pushed a commit
that referenced
this pull request
Apr 17, 2025
jdaugherty
pushed a commit
that referenced
this pull request
Apr 22, 2025
…12.1 (#340) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see discussion on #292. I was going include junit-dep to avoid multiple versions of junit, but Spock is now on 4.11 too and removed junit-dep.
I ran the entire test suite and all tests pass! :)