GPMONGODB-24: CLONE -Dynamic finders returning multiple objects are not wrapped as domain objects

[graemerocher]

Original Reporter: nugsie
Environment: MongoDB Plugin 1.0-M4, Grails 1.3.7, Java 1.6, Linux (Ubuntu 10)
Version: Not Specified
Migrated From: http://jira.grails.org/browse/GPMONGODB-24

When using list() or findAll*() methods, the plugin returns lists of named BasicDBObjects. This is inconsistent with the behaviour of the finders returning single objects which correctly return wrapped domain object instances.

This means 2 crucial things:

1. instanceOf() method isn't bound and any comparison to other domain objects (ie ones that haven't been returned as BasicDBObjects) will return false

2. The id property will not be correctly mapped as the underlying implementation is _id so it's not exposed in the BasicDBObject as 'id'

Whilst other properties are correct so for the most part it can feel as if things are functioning normally this is quite a problem.

Test case app attached to demonstrate the problem both with list() and findAll*() along with a proof that general single finders are working ok.

[graemerocher]

nugsie said:
This issue is still present for me in the 1.0-M5 release and is a blocker for what we're currently working on.

[graemerocher]

nugsie said:
Cloned off GPMONGODB-19

[graemerocher]

nugsie said:
Attachments showing the objects returned from list/findAllBy_/findBy_ queries illustrating that where multiple results are returned, they are not correctly wrapped as domain objects.

[graemerocher]

nugsie said:

[graemerocher]

burtbeckwith said:
Same fix as GPMONGODB-10, https://github.com/SpringSource/spring-data-mapping/commit/6dbac1acfcbb42ebc8a8fc852ba2af0240c84c1b

[graemerocher]

nugsie said:
Great - looks good this time. Verified working ok for me on a git checkout. Thanks Burt!