docs: specify a domain class name when securityConfigType is Requestmap #1187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Current failures should be resolved once #1186 is merged. |
matrei
reviewed
Oct 23, 2025
Contributor
matrei
left a comment
matrei
left a comment
There was a problem hiding this comment.
I think some confusion could be avoided if the example "requestmap" domain classes in the documentation was not named Requestmap but MyRequestMap or something different than the config key. Also there seems to be a typo in section 3.7, where the domain class is named RequestMap (uppercase M) in the code example but adjacent text uses Requestmap (lowercase m).
matrei
force-pushed
the
bkoehm.7.0.x.1179
branch
from
65d1f1a to
9f90f67
Compare
docs: update requestmap docs
Contributor
Author
matrei
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #1179