[Improvement] Make RocksDB related configuaration can be tuned by user

[yuqi1129]

Describe the feature

In gravition, All RocksDB instances use the default configuration for simplicity. It's necessary for us to make the configuration tunable.

such as the ReadOptions and WriteOptions

Motivation

No response

Describe the solution

No response

Additional context

No response

[unknowntpo]

Implementation Plan:

User can set these options through:

gravitino.entity.store.kv.rocksdb.options.<params>
gravitino.entity.store.kv.rocksdb.writeOptions.<params>
gravitino.entity.store.kv.rocksdb.readOptions.<params>

and in RocksDBKvBackend, we can get these configs from Config.

Now, we need to list some parameters here that can be tuned by user.

Note that there are some parameters that might cause data loss, in my opinion, we shouldn't expose this parameter to user.

e.g. setDisableWAL

Reference:

• javadoc.iohttps://javadoc.io › org › rocksdbWriteOptions
• javadoc.iohttps://javadoc.io › org › rocksdbReadOptions
• Options
• setDisableWAL

[yuqi1129]

@unknowntpo
Thank you for your kind work, it's looks fine for me currently, Gravitino can extract the value <params> and pass it to RocksDB. If you have free time, please go ahead.

[unknowntpo]

Okay, I'll keep doing research for this.

@yuqi1129 should I list parameters here or in a new document?

[unknowntpo]

BTW, I found that TiKV has several options about configuring underlying RocksDB, we can refer to their document, and pick some parameters that works for us.

https://tikv.org/docs/3.0/tasks/configure/rocksdb/

[yuqi1129]

BTW, I found that TiKV has several options about configuring underlying RockDB, we can refer to their document, and pick some parameters that works for us.

tikv.org/docs/3.0/tasks/configure/rocksdb

It's best to do so. You only list some common configurations for RocksDB, and for the rest, it's the users who are responsible for them, what you need to do is make the users set these configurations, that is: assuming users add those configuration items in the conf file:

gravitino.entity.store.kv.rockdb.writeOptions.k1 = v1
gravitino.entity.store.kv.rockdb.writeOptions.k2 = v2

Then, you can pass the k1/v1 and k2/v2 to RocskDB instance.

[unknowntpo]

for the rest, it's the users who are responsible for them, what you need to do is make the users set these configurations,

@yuqi1129 Does it means that if user want to set a config that we haven't provide:

gravitino.entity.store.kv.rockdb.writeOptions.k1 = v1

then, we need to use java.lang.reflect.Method to invoke this method on WriteOption instance ?

I think this will give user too much power and even set the wrong configuration that will break the integrity of Gravatino, and if user report these kind of bugs, it's really hard to find the root cause.

Please correct me if l misunderstood what you mean :)

[yuqi1129]

Using reflection is not very elegant in general. Perhaps you can keep a set of configuration items that commonly use in memory,if users set k1 = v1, then we can do the following things:

if (configuratinsSet.contains("k1")) {
then set options
}

That would be straightforward to implement.

[unknowntpo]

So we only handle the configs that are inside this configurationsSet,
and ignore the rest, right?
I think this makes sense.

[yuqi1129]

I believe that in the beginning, we can do it this way.

[unknowntpo]

Okay, I'll start the implementation.