[MINOR] docs(table-maintenance-service): fix optimizer quick-start rewrite log verification#10370
Merged
roryqi merged 2 commits intoapache:mainfrom Mar 11, 2026
Merged
[MINOR] docs(table-maintenance-service): fix optimizer quick-start rewrite log verification#10370roryqi merged 2 commits intoapache:mainfrom
roryqi merged 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@jerryshao @roryqi PTAL |
roryqi
approved these changes
Mar 11, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Mar 11, 2026
…write log verification (#10370) ### What changes were proposed in this pull request? This PR updates the TMS quick-start verification command in `docs/table-maintenance-service/optimizer-quick-start.md`: - In step 7, use `log_dir` and grep rewrite summary lines from `output.log`. - Keep the verification command aligned with actual built-in rewrite job output. ### Why are the changes needed? During end-to-end validation on Gravitino 1.2.0, rewrite summary lines such as: - `Rewritten data files: <N>` - `Added data files: <N>` - `Rewrite data files job completed successfully` were written to `output.log`. The previous doc command checked `error.log`, which can cause false-negative verification. Fix: #N/A ### Does this PR introduce _any_ user-facing change? No API or property changes. Only documentation behavior/command guidance is corrected. ### How was this patch tested? Validated by running optimizer quick-start workflow end to end with: - Gravitino: `/Users/fanng/release/1.2.0/gravitino-1.2.0-bin` - Spark: `/Users/fanng/deploy/demo/spark-3.5.3-bin-hadoop3` Observed successful rewrite job and confirmed summary lines exist in: `/tmp/gravitino/jobs/staging/test/builtin-iceberg-rewrite-data-files/<job_id>/output.log`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates the TMS quick-start verification command in
docs/table-maintenance-service/optimizer-quick-start.md:log_dirand grep rewrite summary lines fromoutput.log.Why are the changes needed?
During end-to-end validation on Gravitino 1.2.0, rewrite summary lines such as:
Rewritten data files: <N>Added data files: <N>Rewrite data files job completed successfullywere written to
output.log. The previous doc command checkederror.log,which can cause false-negative verification.
Fix: #N/A
Does this PR introduce any user-facing change?
No API or property changes.
Only documentation behavior/command guidance is corrected.
How was this patch tested?
Validated by running optimizer quick-start workflow end to end with:
/Users/fanng/release/1.2.0/gravitino-1.2.0-bin/Users/fanng/deploy/demo/spark-3.5.3-bin-hadoop3Observed successful rewrite job and confirmed summary lines exist in:
/tmp/gravitino/jobs/staging/test/builtin-iceberg-rewrite-data-files/<job_id>/output.log.