Skip to content

[MINOR] docs(table-maintenance-service): fix optimizer quick-start rewrite log verification#10370

Merged
roryqi merged 2 commits intoapache:mainfrom
FANNG1:dig_issue
Mar 11, 2026
Merged

[MINOR] docs(table-maintenance-service): fix optimizer quick-start rewrite log verification#10370
roryqi merged 2 commits intoapache:mainfrom
FANNG1:dig_issue

Conversation

@FANNG1
Copy link
Copy Markdown
Contributor

@FANNG1 FANNG1 commented Mar 11, 2026

What changes were proposed in this pull request?

This PR updates the TMS quick-start verification command in
docs/table-maintenance-service/optimizer-quick-start.md:

  • In step 7, use log_dir and grep rewrite summary lines from output.log.
  • Keep the verification command aligned with actual built-in rewrite job output.

Why are the changes needed?

During end-to-end validation on Gravitino 1.2.0, rewrite summary lines such as:

  • Rewritten data files: <N>
  • Added data files: <N>
  • Rewrite data files job completed successfully

were written to output.log. The previous doc command checked error.log,
which can cause false-negative verification.

Fix: #N/A

Does this PR introduce any user-facing change?

No API or property changes.
Only documentation behavior/command guidance is corrected.

How was this patch tested?

Validated by running optimizer quick-start workflow end to end with:

  • Gravitino: /Users/fanng/release/1.2.0/gravitino-1.2.0-bin
  • Spark: /Users/fanng/deploy/demo/spark-3.5.3-bin-hadoop3

Observed successful rewrite job and confirmed summary lines exist in:
/tmp/gravitino/jobs/staging/test/builtin-iceberg-rewrite-data-files/<job_id>/output.log.

@FANNG1 FANNG1 added the branch-1.2 Automatically cherry-pick commit to branch-1.2 label Mar 11, 2026
@FANNG1 FANNG1 self-assigned this Mar 11, 2026
@FANNG1
Copy link
Copy Markdown
Contributor Author

FANNG1 commented Mar 11, 2026

@jerryshao @roryqi PTAL

@roryqi roryqi merged commit f5cd793 into apache:main Mar 11, 2026
19 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 11, 2026
…write log verification (#10370)

### What changes were proposed in this pull request?

This PR updates the TMS quick-start verification command in
`docs/table-maintenance-service/optimizer-quick-start.md`:

- In step 7, use `log_dir` and grep rewrite summary lines from
`output.log`.
- Keep the verification command aligned with actual built-in rewrite job
output.

### Why are the changes needed?

During end-to-end validation on Gravitino 1.2.0, rewrite summary lines
such as:

- `Rewritten data files: <N>`
- `Added data files: <N>`
- `Rewrite data files job completed successfully`

were written to `output.log`. The previous doc command checked
`error.log`,
which can cause false-negative verification.

Fix: #N/A

### Does this PR introduce _any_ user-facing change?

No API or property changes.
Only documentation behavior/command guidance is corrected.

### How was this patch tested?

Validated by running optimizer quick-start workflow end to end with:

- Gravitino: `/Users/fanng/release/1.2.0/gravitino-1.2.0-bin`
- Spark: `/Users/fanng/deploy/demo/spark-3.5.3-bin-hadoop3`

Observed successful rewrite job and confirmed summary lines exist in:

`/tmp/gravitino/jobs/staging/test/builtin-iceberg-rewrite-data-files/<job_id>/output.log`.
yuqi1129 pushed a commit that referenced this pull request Mar 11, 2026
…fix optimizer quick-start rewrite log verification (#10370) (#10371)

**Cherry-pick Information:**
- Original commit: f5cd793
- Target branch: `branch-1.2`
- Status: ✅ Clean cherry-pick (no conflicts)

Co-authored-by: FANNG <xiaojing@datastrato.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch-1.2 Automatically cherry-pick commit to branch-1.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants