Skip to content

[MINOR] fix: polish log and error message quality in core, server, and trino-connector#10387

Open
markhoerth wants to merge 1 commit intoapache:mainfrom
markhoerth:fix/message-polish
Open

[MINOR] fix: polish log and error message quality in core, server, and trino-connector#10387
markhoerth wants to merge 1 commit intoapache:mainfrom
markhoerth:fix/message-polish

Conversation

@markhoerth
Copy link
Copy Markdown

This PR improves the English quality of user-facing log messages, exception
messages, and configuration descriptions across core, server, server-common,
trino-connector, and audit modules. All changes are native English speaker
corrections — no logic or functional behavior changes of any kind.

Changes applied consistently:

  • "Can not" / "can not" → "Cannot"
  • "Fail to" → "Failed to"
  • "id" → "ID" when used as an identifier abbreviation
  • "SIP" → "SPI" (typo in GravitinoConnectorPluginManager)
  • "Grivitino" → "Gravitino" (typo in GravitinoConfig)
  • Removed trailing periods from log and exception messages
  • Fixed missing spaces after colons in log messages
  • Fixed non-idiomatic phrasing ("would better use", "throw a exception", "occurs an unexpected")
  • Improved GravitinoConfig property descriptions for clarity
  • Removed a placeholder dev comment left in production code

A follow-on PR will cover the catalogs modules.

@markhoerth
Copy link
Copy Markdown
Author

@jerryshao FYI — first PR contribution, happy to adjust anything that doesn't fit the project's conventions. A follow-on PR for the catalogs modules is planned.

@yuqi1129
Copy link
Copy Markdown
Contributor

You can use ./gradlew spotlessApply to fix all possible formating problem before pushing code.

@jerryshao
Copy link
Copy Markdown
Contributor

@yuqi1129 can you help on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants