[#7976] improvement(build): Support compiling Gravitino with JDK 21#11124
Open
singhvishalkr wants to merge 1 commit into
Open
[#7976] improvement(build): Support compiling Gravitino with JDK 21#11124singhvishalkr wants to merge 1 commit into
singhvishalkr wants to merge 1 commit into
Conversation
…K 21 The Spotless Gradle plugin version 6.11.0 had an issue with JDK 21 that was fixed in version 6.19.0 (diffplug/spotless#1819). This change upgrades the Spotless plugin to 6.25.0 and updates the JDK version check to allow both JDK 17 and JDK 21 for building Gravitino. Signed-off-by: Vishal Kumar Singh <vishal.kr.singh2021@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #7976 by enabling Gravitino to be compiled with JDK 21.
The Spotless Gradle plugin version 6.11.0 had an issue when running against JDK 21, which was fixed in version 6.19.0 (see diffplug/spotless#1819). I upgraded the plugin to 6.25.0 (current stable) and updated the JDK version check in build.gradle.kts to allow both JDK 17 and 21.
Changes:
Tested locally with JDK 17 (verified existing behavior works). The JDK 21 path now applies the spotless plugin instead of throwing a GradleException.