Skip to content

[#4077] improvement(docs): Fixed an incorrect description and some incomplete examples#4146

Merged
jerryshao merged 2 commits intoapache:mainfrom
JinsYin:patch-2
Jul 15, 2024
Merged

[#4077] improvement(docs): Fixed an incorrect description and some incomplete examples#4146
jerryshao merged 2 commits intoapache:mainfrom
JinsYin:patch-2

Conversation

@JinsYin
Copy link
Contributor

@JinsYin JinsYin commented Jul 12, 2024

What changes were proposed in this pull request?

Fixed an incorrect description.

Why are the changes needed?

Fix: #4145

Does this PR introduce any user-facing change?

No

How was this patch tested?

No testing required

@JinsYin JinsYin changed the title [#4077] improvement(docs): Fixed an incorrect description [#4077] improvement(docs): Fixed an incorrect description and some incomplete examples Jul 12, 2024
@jerryshao
Copy link
Contributor

@yuqi1129 @diqiu50 please help to review this.


## Create catalog

Trino itself does not support creating catalogs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diqiu50
Please help to clarify it, thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the current minimum support version and required, removing this sentence is ok.

Copy link
Contributor

@diqiu50 diqiu50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


## Create catalog

Trino itself does not support creating catalogs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the current minimum support version and required, removing this sentence is ok.

@jerryshao jerryshao merged commit 0961af3 into apache:main Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] This paragraph "Trino itself does not support creating catalogs" is incorrect

4 participants