[#4195] improvement(core): Decouple OperationDispatcher from NormalizeDispatcher#4196
Merged
jerryshao merged 1 commit intoapache:mainfrom Jul 19, 2024
Merged
[#4195] improvement(core): Decouple OperationDispatcher from NormalizeDispatcher#4196jerryshao merged 1 commit intoapache:mainfrom
OperationDispatcher from NormalizeDispatcher#4196jerryshao merged 1 commit intoapache:mainfrom
Conversation
Contributor
|
I cannot get the purpose of this refactoring, can you please explain more about it? |
mchades
commented
Jul 19, 2024
Comment on lines
+39
to
+41
| private final SchemaDispatcher dispatcher; | ||
|
|
||
| private final SchemaOperationDispatcher dispatcher; | ||
|
|
||
| public SchemaNormalizeDispatcher(SchemaOperationDispatcher dispatcher) { | ||
| public SchemaNormalizeDispatcher(SchemaDispatcher dispatcher, CatalogManager catalogManager) { |
Contributor
Author
There was a problem hiding this comment.
The key to refactoring is here, replacing SchemaOperationDispatcher with SchemaDispatcher.
In the decorator design pattern, we should depend on interface SchemaDispatcher instead of the concrete implementation class SchemaOperationDispatcher.
@jerryshao
jerryshao
approved these changes
Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
OperationDispatcherfromNormalizeDispatchergetCatalogCapabilitymethod fromOperationDispatchertoCapabilityHelpersWhy are the changes needed?
Fix: #4195
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests