[#4182] improvement: close the input file stream#4224
Merged
justinmclean merged 1 commit intoapache:mainfrom Jul 22, 2024
Merged
[#4182] improvement: close the input file stream#4224justinmclean merged 1 commit intoapache:mainfrom
justinmclean merged 1 commit intoapache:mainfrom
Conversation
Signed-off-by: pravo23 <pravo23@192.168.1.6>
| try (FileInputStream input = new FileInputStream(configFileName)) { | ||
| properties.load(input); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Thanks for helping out here. Is this code complete as it looks like the input stream is still not closed?
Contributor
There was a problem hiding this comment.
@justinmclean
The try/catch code block will close the input automatically, please refer to try-with-resource
justinmclean
approved these changes
Jul 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added
tryblock for handling file input operations to ensure the file is properly closed even if an error occurs.Why are the changes needed?
Fix: #4182
Does this PR introduce any user-facing change?
No
How was this patch tested?
existing tests