Skip to content

[#4294] improvement(catalogs): Improved readability of trinomial operator usage code#4297

Merged
yuqi1129 merged 19 commits intoapache:mainfrom
khmgobe:fixed/ternary-operation
Jul 30, 2024
Merged

[#4294] improvement(catalogs): Improved readability of trinomial operator usage code#4297
yuqi1129 merged 19 commits intoapache:mainfrom
khmgobe:fixed/ternary-operation

Conversation

@khmgobe
Copy link
Contributor

@khmgobe khmgobe commented Jul 29, 2024

What changes were proposed in this pull request?

Change the trinomial operator usage code to make it easier to understand

Why are the changes needed?

Improved readability

Fix: #4294

Does this PR introduce any user-facing change?

No

How was this patch tested?

Check change code and existing code comparison

khmgobe added 18 commits July 23, 2024 19:01
# Conflicts:
#	core/src/main/java/org/apache/gravitino/proto/RoleEntitySerDe.java
@yuqi1129
Copy link
Contributor

@khmgobe
Please change your PR description according to the PR template.

@khmgobe
Copy link
Contributor Author

khmgobe commented Jul 29, 2024

@khmgobe Please change your PR description according to the PR template.

@yuqi1129 My mistake. I'm sorry. I've changed the description, so please check it

Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuqi1129 yuqi1129 merged commit a8e9a31 into apache:main Jul 30, 2024
@khmgobe khmgobe deleted the fixed/ternary-operation branch July 30, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Use of nested ternary operation is a little confusing

3 participants