[#4185] improvement(core, catalogs): Change the @VisibleForTesting in production code to change usability #4304
Closed
khmgobe wants to merge 20 commits intoapache:mainfrom
khmgobe:fixed/modify@VisibleForTestingCode
Closed
[#4185] improvement(core, catalogs): Change the @VisibleForTesting in production code to change usability #4304khmgobe wants to merge 20 commits intoapache:mainfrom khmgobe:fixed/modify@VisibleForTestingCode
khmgobe wants to merge 20 commits intoapache:mainfrom
khmgobe:fixed/modify@VisibleForTestingCode
Conversation
Contributor
Author
|
@justinmclean Always Have a Goot Time .. ! Among some pager codes that I tried to remove the annotation, I removed the pager because it was in read-only mode where the annotation was directly located. Please note. |
Contributor
Author
|
@yuqi1129 |
Member
|
You need to run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Modifying declaration parts, removing calls that do not need to be used
Why are the changes needed?
It shouldn't be used, but it's declared
Fix: #4185
Does this PR introduce any user-facing change?
No
How was this patch tested?
Check change code and existing code comparison