Skip to content

[#4255] feat(docs): Add docs for Tag System#4308

Merged
yuqi1129 merged 3 commits intoapache:mainfrom
jerryshao:issue-4255
Aug 1, 2024
Merged

[#4255] feat(docs): Add docs for Tag System#4308
yuqi1129 merged 3 commits intoapache:mainfrom
jerryshao:issue-4255

Conversation

@jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

This PR proposes to add docs for tag system.

Why are the changes needed?

To let users know how to use tag system.

Fix: #4255

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manual test.

@jerryshao jerryshao requested review from mchades and yuqi1129 July 30, 2024 07:25
@jerryshao
Copy link
Contributor Author

@yuqi1129 @mchades can you please help me to review doc part. This PR also contains IT part, I will rebase when that PR is merged.

@jerryshao jerryshao marked this pull request as draft July 30, 2024 11:04
@jerryshao jerryshao self-assigned this Jul 30, 2024
@mchades
Copy link
Contributor

mchades commented Jul 30, 2024

why marked this pull request as draft?

@jerryshao
Copy link
Contributor Author

I need to rebase this when #4257 this is done.

@jerryshao jerryshao marked this pull request as ready for review July 31, 2024 05:58
@jerryshao
Copy link
Contributor Author

@mchades @yuqi1129 @jerqi this PR is ready for review, please help to review, thanks.

Copy link
Contributor

@mchades mchades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

@jerryshao jerryshao requested review from mchades and yuqi1129 August 1, 2024 03:56
Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except a minor one.

Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

## Introduction

Starting from 0.6.0, Gravitino introduces a new tag system that allows you to manage tags for
metadata objects. Tags are a way to categorize and organize metadata objects in Gravitino.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagging is a way to categorize and organize metadata objects in Gravitino.

How about? Tagging is an action. It may be better.

@yuqi1129 yuqi1129 merged commit 2f8ec3e into apache:main Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Subtask] Add documentation about how to use Tag system.

4 participants