[#1903] feat(clients): add equals for GravitinoMetalake.#4448
[#1903] feat(clients): add equals for GravitinoMetalake.#4448jerryshao merged 7 commits intoapache:mainfrom
GravitinoMetalake.#4448Conversation
LindaSummer
force-pushed
the
feature/add_equal
branch
2 times, most recently
from
77ec8bb to
3d0fcdb
Compare
|
There are some code formatting issues here. You'll need to run |
Thanks very much for your suggestions! Best Regards, |
LindaSummer
force-pushed
the
feature/add_equal
branch
from
3d0fcdb to
6553370
Compare
| } | ||
|
|
||
| GravitinoMetalake that = (GravitinoMetalake) o; | ||
| return super.equals(that) && Objects.equal(restClient, that.restClient); |
There was a problem hiding this comment.
I feel like that we don't need to compare the restClient object. If the same metalake is gotten from different clients, I think though restClient is different, the GravitinoMetalake itself should be the same.
There was a problem hiding this comment.
Hi @jerryshao ,
Thanks for your suggestions!
I will remove the restClient comparison.
Best Regards,
Edward
|
Thanks @LindaSummer for your contribution, merging to main and branch-0.6. |
### What changes were proposed in this pull request? Add `equals()` and unit tests for `GravitinoMetalake`. ### Why are the changes needed? As issue mentioned, `GravitinoMetalake` class should have an equals method. Fix: #1903 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Unit test cases has been added.
3 participants
What changes were proposed in this pull request?
Add
equals()and unit tests forGravitinoMetalake.Why are the changes needed?
As issue mentioned,
GravitinoMetalakeclass should have an equals method.Fix: #1903
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test cases has been added.