[#4460] feat(core): Add the method call of the authorizationPlugin#4461
Merged
xunliu merged 6 commits intoapache:mainfrom Aug 19, 2024
Merged
[#4460] feat(core): Add the method call of the authorizationPlugin#4461xunliu merged 6 commits intoapache:mainfrom
xunliu merged 6 commits intoapache:mainfrom
Conversation
xunliu
reviewed
Aug 9, 2024
Member
xunliu
left a comment
xunliu
left a comment
There was a problem hiding this comment.
Can you add a mock TestCatalog authorization in this PR?
Just like this, https://github.com/apache/gravitino/blob/main/core/src/test/java/org/apache/gravitino/connector/authorization/TestAuthorization.java
roryqi
force-pushed
the
ISSUE-4460
branch
2 times, most recently
from
db5b14a to
62770c1
Compare
xunliu
requested changes
Aug 19, 2024
Member
xunliu
left a comment
xunliu
left a comment
There was a problem hiding this comment.
Please add schema's role integration test in the AccessControlIT.
roryqi
added a commit
to qqqttt123/gravitino
that referenced
this pull request
Aug 22, 2024
…gin (apache#4461) ### What changes were proposed in this pull request? If we want to push the privileges down the underlying system, we need to call methods of the underlying system authorization plugin. ### Why are the changes needed? Fix: apache#4460 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add some test cases.
roryqi
added a commit
to qqqttt123/gravitino
that referenced
this pull request
Aug 22, 2024
…gin (apache#4461) ### What changes were proposed in this pull request? If we want to push the privileges down the underlying system, we need to call methods of the underlying system authorization plugin. ### Why are the changes needed? Fix: apache#4460 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add some test cases.
roryqi
added a commit
to qqqttt123/gravitino
that referenced
this pull request
Aug 22, 2024
…gin (apache#4461) ### What changes were proposed in this pull request? If we want to push the privileges down the underlying system, we need to call methods of the underlying system authorization plugin. ### Why are the changes needed? Fix: apache#4460 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add some test cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If we want to push the privileges down the underlying system, we need to call methods of the underlying system authorization plugin.
Why are the changes needed?
Fix: #4460
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add some test cases.