Skip to content

[#4706] fix(build): Add license, notice, and other files to the binary artifact#4726

Merged
xunliu merged 2 commits intoapache:mainfrom
jerryshao:issue-4706
Aug 28, 2024
Merged

[#4706] fix(build): Add license, notice, and other files to the binary artifact#4726
xunliu merged 2 commits intoapache:mainfrom
jerryshao:issue-4706

Conversation

@jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

This PR proposes to add several missing license, notice, and other files to the binary artifacts for Gravitino.

Why are the changes needed?

To follow ASF's policy

Fix: #4706

Does this PR introduce any user-facing change?

No.

How was this patch tested?

N/A

@jerryshao jerryshao self-assigned this Aug 28, 2024
@jerryshao jerryshao requested review from FANNG1, roryqi and xunliu August 28, 2024 04:50
@jerryshao
Copy link
Contributor Author

@justinmclean , would you please help to review this PR?

Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xunliu xunliu merged commit 5801b2b into apache:main Aug 28, 2024
github-actions bot pushed a commit that referenced this pull request Aug 28, 2024
…y artifact (#4726)

### What changes were proposed in this pull request?

This PR proposes to add several missing license, notice, and other files
to the binary artifacts for Gravitino.

### Why are the changes needed?

To follow ASF's policy

Fix: #4706 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

N/A
@justinmclean
Copy link
Member

I'd need to look at the final artifact to double-check, but the approach seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] There are no LICENSE files in python and trino packages

3 participants