[#2254] feat: support python client to create table#4824
[#2254] feat: support python client to create table#4824Lanznx wants to merge 25 commits intoapache:mainfrom
Conversation
|
Hi @Lanznx thanks a lot for your contribution. I think the current PR is still super large for review. For this kind of large PR, I would suggest we have a design doc and break down into small subtasks, which will be easy to review and track. CC @noidname01 @xunliu to also take a look. |
|
@Lanznx Thank you for your contribustions.
There is no new design for the python client, it is just rewritten in the python programming language following the java client implementation. If we follow the initial java client way, one small PR step by step commit, then it may take us about the same time as the java client to finish the python client development, which I guess will be very long. And the java client keeps adding new features, then the python client keeps catching up. |
I don't agree that we should be in a hurry to get everything merged in one PR and catch up with the Java client ASAP.
Anyway, from my point, this Python table API work should have a design doc, a community discussion and vote, and a plan before the code works. That's also how the community works. |
What changes were proposed in this pull request?
listTables,loadTable,alterTable, anddropTable.createTablemethod.createTablemethod supports only the required arguments. Optional components such aspartitions,distribution,sort_orders, andindexesare not implemented.Why are the changes needed?
To satisfy the requirements of #2254.
Does this PR introduce any user-facing change?
Yes, it introduces the
create_tableAPI.How was this patch tested?
test_relational_catalog.py, which requires MySQL to be running during the test.