[#4795] feat(core): Add column entity in Gravitino#4866
Merged
jerryshao merged 1 commit intoapache:mainfrom Sep 13, 2024
Merged
[#4795] feat(core): Add column entity in Gravitino#4866jerryshao merged 1 commit intoapache:mainfrom
jerryshao merged 1 commit intoapache:mainfrom
Conversation
yuqi1129
reviewed
Sep 9, 2024
| public static final Field AUDIT_INFO = | ||
| Field.required("audit_info", AuditInfo.class, "The audit details of the table"); | ||
| public static final Field COLUMNS = | ||
| Field.optional("columns", ColumnEntity[].class, "The columns of the table"); |
Contributor
There was a problem hiding this comment.
Why do you mark it as optional? Just to make it compatible with the previous version?
Contributor
Author
There was a problem hiding this comment.
Yes, it is mainly for compatible thinking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a basic implementation of ColumnEntity in Gravitino.
Why are the changes needed?
This is the first PR to let Gravitino to manage columns in its store.
Fix: #4795
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add UTs to test.