[#4551] feat(iceberg): add S3 and GCS support for IcebergRESTService docker image#5243
Merged
FANNG1 merged 3 commits intoapache:mainfrom Oct 30, 2024
Merged
[#4551] feat(iceberg): add S3 and GCS support for IcebergRESTService docker image#5243FANNG1 merged 3 commits intoapache:mainfrom
FANNG1 merged 3 commits intoapache:mainfrom
Conversation
FANNG1
changed the title
Contributor
Author
|
@jerryshao @yuqi1129 @jerqi please help to review, thanks |
yuqi1129
reviewed
Oct 29, 2024
dev/docker/iceberg-rest-server/iceberg-rest-server-dependency.sh
Outdated
Show resolved
Hide resolved
Contributor
|
Please update the doc |
Contributor
Author
updated, please help to review again |
yuqi1129
reviewed
Oct 30, 2024
Contributor
Author
|
@yuqi1129 any other comments? @jerryshao do you have time to review again? |
Contributor
I have no further comments. |
yuqi1129
approved these changes
Oct 30, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
…docker image (#5243) ### What changes were proposed in this pull request? 1. add AWS and GCP bundle jar to IcebergRESTServer docker image 2. use environment variable to change the config ### Why are the changes needed? Fix: #4551 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? run SQL with access S3 and GCS data
mplmoknijb
pushed a commit
to mplmoknijb/gravitino
that referenced
this pull request
Nov 6, 2024
…rvice docker image (apache#5243) ### What changes were proposed in this pull request? 1. add AWS and GCP bundle jar to IcebergRESTServer docker image 2. use environment variable to change the config ### Why are the changes needed? Fix: apache#4551 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? run SQL with access S3 and GCS data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #4551
Does this PR introduce any user-facing change?
no
How was this patch tested?
run SQL with access S3 and GCS data