[#5455] feat(web): disable to update the reserved fields of table properties#5643
[#5455] feat(web): disable to update the reserved fields of table properties#5643jerryshao merged 4 commits intoapache:mainfrom
Conversation
orenccl
force-pushed
the
feat/reservedTableProp
branch
from
c7b4727 to
1f0bddf
Compare
web/web/src/lib/utils/initial.js
Outdated
| } | ||
|
|
||
| export const getRelationalTablePropInfo = catalog => { | ||
| if (Object.keys(relationalTablePropInfoMap).includes(catalog)) { |
There was a problem hiding this comment.
How about
| if (Object.keys(relationalTablePropInfoMap).includes(catalog)) { | |
| if (Object.hasOwn(relationalTablePropInfoMap, catalog)) { |
There was a problem hiding this comment.
Thank you!
This is a better approach and has already been updated.
Would you mind optimizing the length of the input by the way?
And disabled the immutable properties
|
|
Hi @LauraXia123, I’ve updated the properties field width and the reserved/immutable column settings. However, I noticed that some properties appear to be immutable but are not mentioned in the documentation:
I’ve marked them as immutable in the code, but I’m not certain if this is the correct approach. Could you please confirm? |
Yes, these properties are immutable. |
|
Okay, then it's ready for review. |
|
Thank you for your contributions. LGTM |
4 participants
What changes were proposed in this pull request?
Disable the creation or update of reserved fields in table properties.
Why are the changes needed?
Fix #5455.
Does this PR introduce any user-facing changes?
Users will no longer be able to create or update reserved fields in table properties.
How was this patch tested?
Tested by attempting to create or update reserved fields in table properties to ensure it is not allowed.