[#5648] improvement(iceberg): generate credential according to the data path and metadata path#5698
Merged
xunliu merged 5 commits intoapache:mainfrom Nov 28, 2024
Merged
Conversation
FANNG1
reviewed
Nov 28, 2024
| credentialProvider, | ||
| new String[] { | ||
| loadTableResponse.tableMetadata().location(), | ||
| loadTableResponse.tableMetadata().property(TableProperties.WRITE_DATA_LOCATION, ""), |
Contributor
There was a problem hiding this comment.
it's odd to pass an empty path if the specific properties is not set, could you add a check before adding the extra paths?
FANNG1
reviewed
Nov 28, 2024
| propertiesMap.get(TableProperties.WRITE_METADATA_LOCATION), | ||
| String.format( | ||
| "Expected write.metadata.path to be '%s', but was '%s'", | ||
| writeMetaDataPath, propertiesMap.get(TableProperties.WRITE_METADATA_LOCATION))); |
Contributor
There was a problem hiding this comment.
could you try to write and read some data?
Collaborator
Author
|
Seems like occasional error |
FANNG1
reviewed
Nov 28, 2024
| } | ||
|
|
||
| @Test | ||
| void testWritePathCredential() { |
Contributor
There was a problem hiding this comment.
could you rename the test name to testCredentialWithMultiLocations?
Contributor
|
Great work @orenccl , I verified feature succussfully in my local environment, LGTM except one minor comments, could you fix it? |
Collaborator
Author
|
I think the CI is broken, maybe wait till tomorrow 🤷♂️😂 |
FANNG1
approved these changes
Nov 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates the credential generation process to also consider
write.data.pathandwrite.metadata.path.Why are the changes needed?
To provide greater flexibility for users.
Fixes: #5648
Does this PR introduce any user-facing change?
No.
How was this patch tested?
write.data.pathandwrite.metadata.pathare working as expected.write.data.pathandwrite.metadata.path.