[#5700] feat(CLI):Add extended help for catalogs in Gravitino CLI#5703
Merged
justinmclean merged 2 commits intoapache:mainfrom Dec 2, 2024
Merged
[#5700] feat(CLI):Add extended help for catalogs in Gravitino CLI#5703justinmclean merged 2 commits intoapache:mainfrom
justinmclean merged 2 commits intoapache:mainfrom
Conversation
chenyuan99
changed the title
Contributor
Author
|
@justinmclean this is ready to review |
Member
|
The change looks good to me, except the Java path doesn't match the Rat exclusion path. The Java file is in the wrong place I think. |
Contributor
Author
|
@justinmclean fixed the path issue, Thanks for the heads up! |
Contributor
|
Looks like this file misses the license header, I'm curious why it can still pass the CI? |
Contributor
Author
I think @justinmclean excluded txt files for the client help txt files in the rat config |
Contributor
|
OK, I see. |
jerryshao
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added extended help for catalog commands.
Why are the changes needed?
To provide user with extra help.
Fix: #5700
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A