Skip to content

[#5707] fix(web): edit some table would encounter the error: TypeError: e.type.match is not a function #5762

Merged
xunliu merged 1 commit intoapache:mainfrom
orenccl:fix/tableColumnType
Dec 5, 2024
Merged

[#5707] fix(web): edit some table would encounter the error: TypeError: e.type.match is not a function #5762
xunliu merged 1 commit intoapache:mainfrom
orenccl:fix/tableColumnType

Conversation

@orenccl
Copy link
Collaborator

@orenccl orenccl commented Dec 4, 2024

What changes were proposed in this pull request?

Handle unsupported column types.

Why are the changes needed?

Fix: #5707

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Tested by opening a table containing unsupported column types (e.g., list, map, struct).
image

@orenccl orenccl self-assigned this Dec 4, 2024
@orenccl
Copy link
Collaborator Author

orenccl commented Dec 4, 2024

Hi, @LauraXia123
Please take a look when you have a moment.

@orenccl orenccl requested a review from LauraXia123 December 4, 2024 15:08
@LauraXia123
Copy link
Contributor

Thank you for your contribution. @orenccl
LGTM

Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orenccl Thank you for your contributions.
LGTM

@xunliu xunliu merged commit 1fee89c into apache:main Dec 5, 2024
@orenccl orenccl deleted the fix/tableColumnType branch December 5, 2024 05:45
jerryshao pushed a commit that referenced this pull request Dec 6, 2024
…r: e.type.match (#5762)

### What changes were proposed in this pull request?

Handle unsupported column types.

### Why are the changes needed?

Fix: #5707

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Tested by opening a table containing unsupported column types (e.g.,
list, map, struct).

![image](https://github.com/user-attachments/assets/1df87e3b-8142-4001-a257-c99a390b35d9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug report] UI: edit some table would encounter the error: TypeError: e.type.match is not a function

3 participants