[#5822] Print Help information when the help option is passed#5852
Merged
shaofengshi merged 9 commits intoapache:mainfrom Dec 17, 2024
Merged
[#5822] Print Help information when the help option is passed#5852shaofengshi merged 9 commits intoapache:mainfrom
shaofengshi merged 9 commits intoapache:mainfrom
Conversation
Contributor
Author
|
Hi @justinmclean @xunliu, would you mind reviewing my code when you have a moment? |
Abyss-lord
changed the title
Member
|
The help files have already been added in PR #5809 |
Contributor
Author
ok @justinmclean , than I just change the code and delete the help file |
Contributor
Author
|
Hi @justinmclean, I just remove those help files |
…option is passed Previously, typing "entity help" displays the help information for that entity. Now, the "entity -help" command will have the same effect.
…option is passed change some comments
Add help files for multiple entities(column, fileset, group, role, table, tag, topic, user)
…ntities" This reverts commit e315401.
…option is passed move help option check to resolveCommand
…option is passed add test to entity + --help option.
…option is passed add new equal assert
Abyss-lord
force-pushed
the
improvement-help
branch
from
2001baf to
53a2640
Compare
tengqm
reviewed
Dec 16, 2024
justinmclean
approved these changes
Dec 17, 2024
Member
justinmclean
left a comment
justinmclean
left a comment
There was a problem hiding this comment.
Thanks again for your contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a small improvement, previously, typing
entity helpwill displays the help information for that entity. Now, theentity --helpcommand will have the same effect.Why are the changes needed?
Fix: #5822
Does this PR introduce any user-facing change?
No
How was this patch tested?