[#5929] improvement(CLI): fix cli details command produce no output#5941
Merged
xunliu merged 3 commits intoapache:mainfrom Dec 23, 2024
Merged
[#5929] improvement(CLI): fix cli details command produce no output#5941xunliu merged 3 commits intoapache:mainfrom
xunliu merged 3 commits intoapache:mainfrom
Conversation
…tput If a user has no roles then no output is produced from user\group details command, it should give some help information.
Contributor
Author
|
Hi @justinmclean @xunliu @tengqm , could you plz review this pr when you have time? |
tengqm
reviewed
Dec 23, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/commands/GroupDetails.java
Outdated
Show resolved
Hide resolved
clients/cli/src/main/java/org/apache/gravitino/cli/commands/UserDetails.java
Outdated
Show resolved
Hide resolved
…oupDetails.java Co-authored-by: Qiming Teng <tengqm@outlook.com>
…erDetails.java Co-authored-by: Qiming Teng <tengqm@outlook.com>
Contributor
Author
|
Hi @justinmclean @tengqm , I’ve finished updating the code. Please take a look at the PR again when you have time. |
Contributor
|
lgtm. |
justinmclean
approved these changes
Dec 23, 2024
Member
justinmclean
left a comment
justinmclean
left a comment
There was a problem hiding this comment.
Thanks for your contribution.
xunliu
approved these changes
Dec 23, 2024
Member
xunliu
left a comment
xunliu
left a comment
There was a problem hiding this comment.
@Abyss-lord Thank you for your contributions.
LGTM
Abyss-lord
added a commit
to Abyss-lord/gravitino
that referenced
this pull request
Dec 23, 2024
…tput (apache#5941) ### What changes were proposed in this pull request? If a user has no roles then no output is produced from `user\group details` command, it should give some help information. ### Why are the changes needed? Fix: apache#5929 ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? ```bash bin/gcli.sh user details -m demo_metalake --user test_user # output: User has no roles. bin/gcli.sh group details -m demo_metalake --group group_no_role # output: Groups has no roles. ``` --------- Co-authored-by: Qiming Teng <tengqm@outlook.com>
Abyss-lord
added a commit
to Abyss-lord/gravitino
that referenced
this pull request
Dec 29, 2024
…tput (apache#5941) ### What changes were proposed in this pull request? If a user has no roles then no output is produced from `user\group details` command, it should give some help information. ### Why are the changes needed? Fix: apache#5929 ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? ```bash bin/gcli.sh user details -m demo_metalake --user test_user # output: User has no roles. bin/gcli.sh group details -m demo_metalake --group group_no_role # output: Groups has no roles. ``` --------- Co-authored-by: Qiming Teng <tengqm@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If a user has no roles then no output is produced from
user\group detailscommand, it should give some help information.Why are the changes needed?
Fix: #5929
Does this PR introduce any user-facing change?
NO
How was this patch tested?