[#6815] feat(server): Support update comment for model version#6987
Merged
jerryshao merged 1 commit intobranch-0.9from Apr 17, 2025
Merged
Conversation
### What changes were proposed in this pull request? Support update comment for model version - [x] PR1: Add ModelVersionChange API interface, Implement the update comment logic in model catalog and JDBC backend logic, update related event. - [X] PR2: Add REST endpoint to support model version change, add Java client and Python client for model version comment update. ### Why are the changes needed? Fix: #6815 ### Does this PR introduce _any_ user-facing change? Add support for updating comments on model versions. Users can now update a model version's comment via the REST API. ### How was this patch tested? local test. original model version comment. <img width="1055" alt="image" src="https://github.com/user-attachments/assets/c74c4dd1-f785-4c74-ae17-d666b06950f0" /> `bin/gcli.sh model update -m demo_metalake --name model_catalog.schema.model2 --version 0 --comment 'new comment'` <img width="1057" alt="image" src="https://github.com/user-attachments/assets/a866371e-df0b-4999-adb6-8543eaff73a3" /> `bin/gcli.sh model update -m demo_metalake --name model_catalog.schema.model2 --alias test --comment 'new comment by alias'` <img width="1070" alt="image" src="https://github.com/user-attachments/assets/2f838272-21a1-45b7-944d-014e45c7a511" />
jerryshao
approved these changes
Apr 17, 2025
jerryshao
deleted the
cherry-pick-branch-0.9-998d2416fdb9b94b06e80c20c895669fb6d6f5f2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support update comment for model version
Why are the changes needed?
Fix: #6815
Does this PR introduce any user-facing change?
Add support for updating comments on model versions. Users can now update a model version's comment via the REST API.
How was this patch tested?
local test.
original model version comment.
bin/gcli.sh model update -m demo_metalake --name model_catalog.schema.model2 --version 0 --comment 'new comment'bin/gcli.sh model update -m demo_metalake --name model_catalog.schema.model2 --alias test --comment 'new comment by alias'