[#7249] Remove unnecessary instanceof check for IOException handling#7253
Merged
justinmclean merged 1 commit intoapache:mainfrom May 26, 2025
Merged
Conversation
justinmclean
approved these changes
May 26, 2025
Member
justinmclean
left a comment
justinmclean
left a comment
There was a problem hiding this comment.
Thanks for your contribution.
vishnu-chalil
pushed a commit
to vishnu-chalil/gravitino
that referenced
this pull request
Jul 14, 2025
…dling (apache#7253) This PR addresses [Issue apache#7249](apache#7249), which pointed out unnecessary use of instanceof in exception handling in GravitinoVirtualFileSystem.java. ``` } catch (IOException e) { if (e instanceof FilesetPathNotFoundException) { throw (FilesetPathNotFoundException) e; } throw e; } ``` This check is redundant since: FilesetPathNotFoundException is a subtype of IOException Both branches simply rethrow the exception ``` } catch (IOException e) { throw e; } ``` Or if this block serves no purpose beyond that, it could be safely removed altogether. Co-authored-by: Dentalkart399 <vasadent399@Dentalkart399s-MacBook-Air.local>
hdygxsj
pushed a commit
to hdygxsj/gravitino
that referenced
this pull request
Jul 15, 2025
…dling (apache#7253) This PR addresses [Issue apache#7249](apache#7249), which pointed out unnecessary use of instanceof in exception handling in GravitinoVirtualFileSystem.java. ``` } catch (IOException e) { if (e instanceof FilesetPathNotFoundException) { throw (FilesetPathNotFoundException) e; } throw e; } ``` This check is redundant since: FilesetPathNotFoundException is a subtype of IOException Both branches simply rethrow the exception ``` } catch (IOException e) { throw e; } ``` Or if this block serves no purpose beyond that, it could be safely removed altogether. Co-authored-by: Dentalkart399 <vasadent399@Dentalkart399s-MacBook-Air.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #7249, which pointed out unnecessary use of instanceof in exception handling in GravitinoVirtualFileSystem.java.
This check is redundant since:
FilesetPathNotFoundException is a subtype of IOException
Both branches simply rethrow the exception
Or if this block serves no purpose beyond that, it could be safely removed altogether.