[#7285][Improvements] Use equalsIgnoreCase instead of upperCase.equals#7306
Merged
jerryshao merged 2 commits intoapache:mainfrom May 30, 2025
Merged
[#7285][Improvements] Use equalsIgnoreCase instead of upperCase.equals#7306jerryshao merged 2 commits intoapache:mainfrom
jerryshao merged 2 commits intoapache:mainfrom
Conversation
jerryshao
approved these changes
May 30, 2025
vishnu-chalil
pushed a commit
to vishnu-chalil/gravitino
that referenced
this pull request
Jul 14, 2025
….equals (apache#7306) ### What changes were proposed in this pull request? Replacing `toUpperCase().equals` with single `equalsIgnoreCase` ### Why are the changes needed? For better code readability Fix: apache#7285 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? ./gradlew clean build
hdygxsj
pushed a commit
to hdygxsj/gravitino
that referenced
this pull request
Jul 15, 2025
….equals (apache#7306) ### What changes were proposed in this pull request? Replacing `toUpperCase().equals` with single `equalsIgnoreCase` ### Why are the changes needed? For better code readability Fix: apache#7285 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? ./gradlew clean build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replacing
toUpperCase().equalswith singleequalsIgnoreCaseWhy are the changes needed?
For better code readability
Fix: #7285
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
./gradlew clean build