[#7469] improvement(trino-connector): Support catalog configuration directly pass through#7562
Merged
diqiu50 merged 1 commit intoapache:mainfrom Jul 4, 2025
Conversation
Contributor
Author
diqiu50
reviewed
Jul 3, 2025
Contributor
diqiu50
left a comment
diqiu50
left a comment
There was a problem hiding this comment.
After reviewing the code, I believe we can remove the original logic in the catalog that maps trino.bypass keys using the TRINO_KEY_TO_GRAVITINO_KEY map. Instead, we can adopt the current trino.bypass.direct. mechanism to handle such configurations.
Contributor
Author
okk, I will make adjustments later! That makes the implementation more concise and user-friendly. |
…tion directly pass through
hqbhoho
force-pushed
the
feat/support_trino_config_bypass_direct
branch
from
b21cd5d to
a4eb2e7
Compare
Contributor
|
It's a really great refactoring, and no obvious problem was found. @diqiu50 , Could you also take time to take a look? |
sdj3261
pushed a commit
to sdj3261/gravitino
that referenced
this pull request
Jul 7, 2025
…tion directly pass through (apache#7562) ### What changes were proposed in this pull request? Support directly pass catalog configuration to the Gravitino catalog in the Trino runtime ### Why are the changes needed? PropertyConverter will skip property which not in `PropertyConverter#engineToGravitinoMapping`, it increases coupling with Trino. We will remove the original logic in the catalog that maps `trino.bypass.` keys using the TRINO_KEY_TO_GRAVITINO_KEY map. Only remove the `trino.bypass.` prefix from the configuration key and directly pass it through. FIx: apache#7469 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? local tests
vishnu-chalil
pushed a commit
to vishnu-chalil/gravitino
that referenced
this pull request
Jul 14, 2025
…tion directly pass through (apache#7562) ### What changes were proposed in this pull request? Support directly pass catalog configuration to the Gravitino catalog in the Trino runtime ### Why are the changes needed? PropertyConverter will skip property which not in `PropertyConverter#engineToGravitinoMapping`, it increases coupling with Trino. We will remove the original logic in the catalog that maps `trino.bypass.` keys using the TRINO_KEY_TO_GRAVITINO_KEY map. Only remove the `trino.bypass.` prefix from the configuration key and directly pass it through. FIx: apache#7469 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? local tests
hdygxsj
pushed a commit
to hdygxsj/gravitino
that referenced
this pull request
Jul 15, 2025
…tion directly pass through (apache#7562) ### What changes were proposed in this pull request? Support directly pass catalog configuration to the Gravitino catalog in the Trino runtime ### Why are the changes needed? PropertyConverter will skip property which not in `PropertyConverter#engineToGravitinoMapping`, it increases coupling with Trino. We will remove the original logic in the catalog that maps `trino.bypass.` keys using the TRINO_KEY_TO_GRAVITINO_KEY map. Only remove the `trino.bypass.` prefix from the configuration key and directly pass it through. FIx: apache#7469 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? local tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support directly pass catalog configuration to the Gravitino catalog in the Trino runtime
Why are the changes needed?
PropertyConverter will skip property which not in
PropertyConverter#engineToGravitinoMapping, it increases coupling with Trino. We will remove the original logic in the catalog that mapstrino.bypass.keys using the TRINO_KEY_TO_GRAVITINO_KEY map. Only remove thetrino.bypass.prefix from the configuration key and directly pass it through.FIx: #7469
Does this PR introduce any user-facing change?
no
How was this patch tested?
local tests