[#7706] improvement: Reuse token in OAuth2TokenProvider’s getTokenData method instead of calling getAccessToken twice#7709
Merged
justinmclean merged 2 commits intoapache:mainfrom Jul 16, 2025
Conversation
justinmclean
approved these changes
Jul 15, 2025
Member
justinmclean
left a comment
justinmclean
left a comment
There was a problem hiding this comment.
Looks good, thanks for looking into this.
Contributor
Author
always happy to help 😄 |
roryqi
changed the title
roryqi
changed the title
roryqi
pushed a commit
to qqqttt123/gravitino
that referenced
this pull request
Jul 30, 2025
…kenData method instead of calling getAccessToken twice (apache#7709) ### What changes were proposed in this pull request? Instead of calling the `getAccessToken()` function twice, we store the returned value in a variable and reuse it within the method. ### Why are the changes needed? The previous approach was inefficient because it invoked the same function twice. With this change, the function is called only once, and the result is cached in a local variable, improving performance and avoiding redundant method calls. Fix: apache#7706
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Instead of calling the
getAccessToken()function twice, we store the returned value in a variable and reuse it within the method.Why are the changes needed?
The previous approach was inefficient because it invoked the same function twice. With this change, the function is called only once, and the result is cached in a local variable, improving performance and avoiding redundant method calls.
Fix: #7706