[#7840] feat(core): Add job status puller and orphan file cleaner#7936
Merged
jerryshao merged 2 commits intoapache:mainfrom Aug 7, 2025
Merged
[#7840] feat(core): Add job status puller and orphan file cleaner#7936jerryshao merged 2 commits intoapache:mainfrom
jerryshao merged 2 commits intoapache:mainfrom
Conversation
yuqi1129
reviewed
Aug 5, 2025
| } | ||
|
|
||
| StringBuffer result = new StringBuffer(); | ||
| StringBuilder result = new StringBuilder(); |
Contributor
There was a problem hiding this comment.
Is there any thread-race problem for StringBuffer here?
Contributor
Author
There was a problem hiding this comment.
I don't know. This is recommended by intelij idea, so I change to use StringBuilder.
yuqi1129
reviewed
Aug 6, 2025
Contributor
yuqi1129
left a comment
yuqi1129
left a comment
There was a problem hiding this comment.
Minor ones, others LGTM.
| || job.status() == JobHandle.Status.FAILED) | ||
| .filter( | ||
| job -> | ||
| job.finishedAt() > 0 |
Contributor
There was a problem hiding this comment.
When will a job status is canceled, succeeded or failed and the finished at is 0?
Contributor
Author
There was a problem hiding this comment.
No, the finished time of the completed job is the current timestamp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the job status pulling thread and orphan file cleaner thread for job manager.
Why are the changes needed?
Fix: #7840
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add UTs.