Skip to content

[#7437] feat(client): Java/Python clients and CLI support model version with multiple URIs#8267

Merged
jerryshao merged 6 commits intoapache:mainfrom
xiaozcy:model-uri-client
Aug 27, 2025
Merged

[#7437] feat(client): Java/Python clients and CLI support model version with multiple URIs#8267
jerryshao merged 6 commits intoapache:mainfrom
xiaozcy:model-uri-client

Conversation

@xiaozcy
Copy link
Contributor

@xiaozcy xiaozcy commented Aug 25, 2025

What changes were proposed in this pull request?

Java/Python clients and CLI support model version with multiple URIs.

Why are the changes needed?

Fix: #7437

Does this PR introduce any user-facing change?

Yes.

How was this patch tested?

UT & IT.

@xiaozcy xiaozcy marked this pull request as ready for review August 26, 2025 08:00
@xiaozcy
Copy link
Contributor Author

xiaozcy commented Aug 26, 2025

Hi @jerryshao , this PR is ready for review, thx~

Map<String, String> queryParam =
uriName == null
? Collections.emptyMap()
: ImmutableMap.of("uriName", RESTUtils.encodeString(uriName));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to encode the query parameter, the Apache Http client will help you to do so:

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Map<String, String> queryParam =
uriName == null
? Collections.emptyMap()
: ImmutableMap.of("uriName", RESTUtils.encodeString(uriName));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here.


[DESIGN]
# Maximum number of return statements allowed in a function
max-returns=10
Copy link
Contributor

@jerryshao jerryshao Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd better not change this, you can add the comment to the place where the code has such an issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jerryshao jerryshao merged commit 83de7c6 into apache:main Aug 27, 2025
28 checks passed
diqiu50 pushed a commit to diqiu50/gravitino that referenced this pull request Sep 15, 2025
… version with multiple URIs (apache#8267)

### What changes were proposed in this pull request?

Java/Python clients and CLI support model version with multiple URIs.

### Why are the changes needed?

Fix: apache#7437

### Does this PR introduce _any_ user-facing change?

Yes.

### How was this patch tested?

UT & IT.

---------

Co-authored-by: zhanghan <zhanghan18@xiaomi.com>
bharos pushed a commit to bharos/gravitino that referenced this pull request Oct 3, 2025
… version with multiple URIs (apache#8267)

### What changes were proposed in this pull request?

Java/Python clients and CLI support model version with multiple URIs.

### Why are the changes needed?

Fix: apache#7437

### Does this PR introduce _any_ user-facing change?

Yes.

### How was this patch tested?

UT & IT.

---------

Co-authored-by: zhanghan <zhanghan18@xiaomi.com>
bharos pushed a commit to bharos/gravitino that referenced this pull request Oct 7, 2025
… version with multiple URIs (apache#8267)

### What changes were proposed in this pull request?

Java/Python clients and CLI support model version with multiple URIs.

### Why are the changes needed?

Fix: apache#7437

### Does this PR introduce _any_ user-facing change?

Yes.

### How was this patch tested?

UT & IT.

---------

Co-authored-by: zhanghan <zhanghan18@xiaomi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Subtask] Java/Python clients and CLI support model version with multiple URIs

2 participants