[#8385] Make JsonCodec.java is thread safe#8399
Merged
justinmclean merged 2 commits intoapache:mainfrom Sep 3, 2025
Merged
Conversation
justinmclean
changed the title
justinmclean
changed the title
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Sep 15, 2025
### What changes were proposed in this pull request? - Made `JsonCodec` thread-safe by marking `mapper` and `jsonType` as `volatile`. - Applied double-checked locking in `getMapper` and `getJsonType` to ensure proper lazy initialization in concurrent scenarios. - No functional changes to the JSON serialization/deserialization behavior. ### Why are the changes needed? - `JsonCodec` was not thread-safe: concurrent access to `mapper` and `jsonType` could cause race conditions or inconsistent initialization. Fix: apache#8385 ### Does this PR introduce any user-facing change? - No user-facing API changes. - No properties or configuration keys were added or removed. - Existing functionality behaves identically, but now safely under concurrent access.
bharos
pushed a commit
to bharos/gravitino
that referenced
this pull request
Oct 3, 2025
### What changes were proposed in this pull request? - Made `JsonCodec` thread-safe by marking `mapper` and `jsonType` as `volatile`. - Applied double-checked locking in `getMapper` and `getJsonType` to ensure proper lazy initialization in concurrent scenarios. - No functional changes to the JSON serialization/deserialization behavior. ### Why are the changes needed? - `JsonCodec` was not thread-safe: concurrent access to `mapper` and `jsonType` could cause race conditions or inconsistent initialization. Fix: apache#8385 ### Does this PR introduce any user-facing change? - No user-facing API changes. - No properties or configuration keys were added or removed. - Existing functionality behaves identically, but now safely under concurrent access.
bharos
pushed a commit
to bharos/gravitino
that referenced
this pull request
Oct 7, 2025
### What changes were proposed in this pull request? - Made `JsonCodec` thread-safe by marking `mapper` and `jsonType` as `volatile`. - Applied double-checked locking in `getMapper` and `getJsonType` to ensure proper lazy initialization in concurrent scenarios. - No functional changes to the JSON serialization/deserialization behavior. ### Why are the changes needed? - `JsonCodec` was not thread-safe: concurrent access to `mapper` and `jsonType` could cause race conditions or inconsistent initialization. Fix: apache#8385 ### Does this PR introduce any user-facing change? - No user-facing API changes. - No properties or configuration keys were added or removed. - Existing functionality behaves identically, but now safely under concurrent access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
JsonCodecthread-safe by markingmapperandjsonTypeasvolatile.getMapperandgetJsonTypeto ensure proper lazy initialization in concurrent scenarios.Why are the changes needed?
JsonCodecwas not thread-safe: concurrent access tomapperandjsonTypecould cause race conditions or inconsistent initialization.Fix: #8385
Does this PR introduce any user-facing change?