Skip to content

[#8481] improvement(Python-CI): remove download hadoop package task#8487

Merged
jerryshao merged 3 commits intoapache:mainfrom
mchades:disable-coverage
Sep 11, 2025
Merged

[#8481] improvement(Python-CI): remove download hadoop package task#8487
jerryshao merged 3 commits intoapache:mainfrom
mchades:disable-coverage

Conversation

@mchades
Copy link
Contributor

@mchades mchades commented Sep 10, 2025

What changes were proposed in this pull request?

  • remove the download Hadoop package task from gradle
  • copy hadoop package from HDFS container

Why are the changes needed?

I noticed that the Python-CI is time-consuming, and the Hadoop package download task takes 2362.881 seconds.

#8481

Does this PR introduce any user-facing change?

no

How was this patch tested?

CI pass

@mchades mchades marked this pull request as draft September 10, 2025 02:55
@mchades mchades closed this Sep 10, 2025
@mchades mchades reopened this Sep 10, 2025
@jerryshao
Copy link
Contributor

@mchades can you please link the PR to this isseu #8481?

@mchades mchades changed the title [MINOR] improvement(Python-CI): disable python tests coverage by default [#8481] improvement(Python-CI): disable python tests coverage by default Sep 10, 2025
@mchades mchades force-pushed the disable-coverage branch 2 times, most recently from bf70c61 to 1652edd Compare September 10, 2025 04:47
@mchades mchades marked this pull request as ready for review September 10, 2025 12:14
@jerryshao
Copy link
Contributor

Please update the PR title and content.

@mchades mchades changed the title [#8481] improvement(Python-CI): disable python tests coverage by default [#8481] improvement(Python-CI): remove download hadoop package from IT Sep 10, 2025
@mchades mchades changed the title [#8481] improvement(Python-CI): remove download hadoop package from IT [#8481] improvement(Python-CI): remove download hadoop package task Sep 10, 2025
args = listOf("scripts/generate_version.py")
}

val downloadHadoopPack by registering(Download::class) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also remove the download plugin in line 27.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

val urlString = "$host:$port/metrics"
val successPattern = Regex("\"version\"\\s*:")

println("Waiting for server to be ready at $urlString (timeout: ${timeout / 1000}s)...")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you keep the debug information?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, it's helpful and not verbose

@mchades mchades added branch-1.0 Automatically cherry-pick commit to branch-1.0 branch-0.9 Automatically cherry-pick commit to branch-0.9 labels Sep 11, 2025
@mchades
Copy link
Contributor Author

mchades commented Sep 11, 2025

All comments have been resolved. Could you please help review again? Thanks. @jerryshao @yuqi1129

@jerryshao jerryshao merged commit 9311734 into apache:main Sep 11, 2025
25 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 11, 2025
…8487)

### What changes were proposed in this pull request?

- remove the download Hadoop package task from gradle
- copy hadoop package from HDFS container

### Why are the changes needed?

I noticed that the Python-CI is time-consuming, and the Hadoop package
download task takes 2362.881 seconds.

#8481 


### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

CI pass
github-actions bot pushed a commit that referenced this pull request Sep 11, 2025
…8487)

### What changes were proposed in this pull request?

- remove the download Hadoop package task from gradle
- copy hadoop package from HDFS container

### Why are the changes needed?

I noticed that the Python-CI is time-consuming, and the Hadoop package
download task takes 2362.881 seconds.

#8481 


### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

CI pass
bharos pushed a commit to bharos/gravitino that referenced this pull request Oct 3, 2025
…task (apache#8487)

### What changes were proposed in this pull request?

- remove the download Hadoop package task from gradle
- copy hadoop package from HDFS container

### Why are the changes needed?

I noticed that the Python-CI is time-consuming, and the Hadoop package
download task takes 2362.881 seconds.

apache#8481 


### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

CI pass
bharos pushed a commit to bharos/gravitino that referenced this pull request Oct 7, 2025
…task (apache#8487)

### What changes were proposed in this pull request?

- remove the download Hadoop package task from gradle
- copy hadoop package from HDFS container

### Why are the changes needed?

I noticed that the Python-CI is time-consuming, and the Hadoop package
download task takes 2362.881 seconds.

apache#8481 


### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

CI pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch-0.9 Automatically cherry-pick commit to branch-0.9 branch-1.0 Automatically cherry-pick commit to branch-1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants