[#8806] feat(client-python): add from_function_arg(s) to DTOConverters#8819
Merged
unknowntpo merged 2 commits intoapache:mainfrom Oct 16, 2025
Merged
Conversation
apache#8806 Signed-off-by: George T. C. Lai <tsungchih.hd@gmail.com>
apache#8806 Signed-off-by: George T. C. Lai <tsungchih.hd@gmail.com>
Collaborator
Author
|
@jerryshao @unknowntpo Could you please help with reviewing this PR when you are available? I would greatly appreciate any feedback from you. Thanks. |
jerryshao
approved these changes
Oct 16, 2025
Contributor
|
LGTM, @unknowntpo would you please also take a look? |
Contributor
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is aimed at implementing the following two methods in class
gravitino.dto.util.dto_converters.DTOConvertersfrom_function_argfrom_function_argsWe can therefore implement the method
from_dtoin the same class.Why are the changes needed?
It's required for implementing table operations.
Fix: #8806
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests