[#8881] improvement(fileset): use fileset write lock instead of schema lock for fileset creation#8880
Merged
yuqi1129 merged 1 commit intoapache:mainfrom Oct 24, 2025
Conversation
youngyjd
changed the title
Contributor
|
LGTM. @yuqi1129 could you please also take a review, thx! |
yuqi1129
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Scope locking down from schema-level to a fileset-level write lock during fileset creation. This allows multiple filesets to be created concurrently within the same schema and should improve create-fileset throughput.
Why are the changes needed?
The schema-wide lock serialized all creations within a schema, becoming a bottleneck. Using a per-fileset write lock reduces contention and increases parallelism. Note: this is a performance–consistency trade-off; during active writes, listing operations may briefly return incomplete results until creations commit.
Fix: #8881
Does this PR introduce any user-facing change?
no
How was this patch tested?
manual testing