[#8957] improvement(catalog-mysql): support more mysql text types#8958
Closed
predator4ann wants to merge 2 commits intoapache:mainfrom
Closed
[#8957] improvement(catalog-mysql): support more mysql text types#8958predator4ann wants to merge 2 commits intoapache:mainfrom
predator4ann wants to merge 2 commits intoapache:mainfrom
Conversation
Signed-off-by: zacsun <zacsun@lilith.com>
Contributor
Author
|
@mchades PTAL when you have time, thanks. |
mchades
reviewed
Oct 29, 2025
| static final String DATETIME = "datetime"; | ||
| static final String TINYTEXT = "tinytext"; | ||
| static final String MEDIUMTEXT = "mediumtext"; | ||
| static final String LONGTEXT = "longtext"; |
Contributor
There was a problem hiding this comment.
you also need to update the relative user doc
mchades
reviewed
Oct 29, 2025
Comment on lines
+103
to
106
| case TINYTEXT: | ||
| case MEDIUMTEXT: | ||
| case LONGTEXT: | ||
| return Types.StringType.get(); |
Contributor
There was a problem hiding this comment.
These four types will cast to the same type String, will this cause user confusion?
Contributor
Author
|
After verification, the data can be read normally in the current state, so it will be closed first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Fix: #8957
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT already added.