Skip to content

[#9100] improvement(trino-connector): Use GravitinoColumnHandle for getTableStatistics in GravitinoMetadata#9101

Merged
diqiu50 merged 2 commits intoapache:mainfrom
hqbhoho:fix/trino_get_table_statistics
Nov 21, 2025
Merged

[#9100] improvement(trino-connector): Use GravitinoColumnHandle for getTableStatistics in GravitinoMetadata#9101
diqiu50 merged 2 commits intoapache:mainfrom
hqbhoho:fix/trino_get_table_statistics

Conversation

@hqbhoho
Copy link
Contributor

@hqbhoho hqbhoho commented Nov 13, 2025

What changes were proposed in this pull request?

Use GravitinoColumnHandle for getTableStatistics in GravitinoMetadata

Why are the changes needed?

Fix: #9100

Does this PR introduce any user-facing change?

No

How was this patch tested?

local test

@hqbhoho
Copy link
Contributor Author

hqbhoho commented Nov 14, 2025

@diqiu50 PTAL, thanks!

@yuqi1129
Copy link
Contributor

@diqiu50
Please help take a look, it's generally okay with me.

value1 int
);
INSERT INTO gt_mysql_test_table_statistics.table01 VALUES (1, 1), (2, 2);
ANALYZE TABLE gt_mysql_test_table_statistics.table01; No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not appropriate to add this to the script, as it will affect other tests. I suggest removing it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add test in iceberg test.

… for getTableStatistics in GravitinoMetadata
@hqbhoho hqbhoho force-pushed the fix/trino_get_table_statistics branch from 5355915 to 4a1d78b Compare November 17, 2025 07:48
@hqbhoho hqbhoho requested a review from diqiu50 November 17, 2025 07:51
@hqbhoho
Copy link
Contributor Author

hqbhoho commented Nov 20, 2025

@diqiu50 Could you merge it if no issues? Thanks!

Copy link
Contributor

@diqiu50 diqiu50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diqiu50 diqiu50 merged commit bec415f into apache:main Nov 21, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Fix getTableStatistics in GravitinoMetadata for Trino connector

3 participants