[#9082] fix(core): validate job run id parsing to avoid SIOOBE#9302
Closed
HaJunYoo wants to merge 1 commit intoapache:mainfrom
Closed
[#9082] fix(core): validate job run id parsing to avoid SIOOBE#9302HaJunYoo wants to merge 1 commit intoapache:mainfrom
HaJunYoo wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
JobMetaService#getJobByIdentifier/deleteJobthroughparseJobRunIdso malformed IDs throwNoSuchEntityExceptioninstead of runtime errors.ident.toString()).@TestTemplatesoBackendTestExtensioncan inject the relational backend per invocation (required for H2/MySQL/PostgreSQL runs).Why are the changes needed?
@TestTemplate; using plain@Testwould bypass it and leave the backend uninitialized.Fix: #9082
Does this PR introduce any user-facing change?
NoSuchEntityExceptioninstead of unexpected runtime errors, improving error consistency.How was this patch tested?
TestJobMetaService#testGetJobWithMalformedIdentifierThrowsNoSuchEntityExceptionTestJobMetaService#testDeleteJobWithMalformedIdentifierThrowsNoSuchEntityException